THIS IS A TEST INSTANCE. ALL YOUR CHANGES WILL BE LOST!!!!
...
Once a change has a +2 and has been verified by a pre-merge verification run, it can be submitted to gerrit. Once it is in is gerrit, a committer needs to push the commit to the Apache git repository, by running:
| Code Block |
|---|
bin/push_to_asf.py |
push_to_asf.py checks the latest commits in gerrit and checks if they are in the Apache git repo. If some are not in the Apache git repo yet, it will ask you if you want to update the Apache git repo with the missing commits found in the Gerrit repo. It does not check what your local state is at all. It only compares remote Gerrit with the remote Apache repo. Keep in mind that if you are a committer, it will allow you to commit any change authored by anyone that has passed GVO.
...
As described above, Gerrit generates one review request per new commit. It's much easier to review everything related to a patch together in one single commit, so please make sure to squash all your related commits together before submitting. If you don't, your review requests will probably get forcibly removed
Other Useful Tools and Information
Searching for all Impala reviews
You might want to bookmark this link, which shows all open reviews for Impala.
git-review (Python Gerrit helper module)
git-review is a Python module that can simplify publishing gerrit reviews. To install it use:
| Code Block |
|---|
sudo pip install git-review
|
By default, git-review will look for a remote named 'gerrit'. The usage is:
| Code Block |
|---|
# Submit a code review (or update an existing review). This will also do a git rebase -i asf-gerrit/master.
git review -r asf-gerrit
|
git-review can be used to apply changes from a review locally and compare patch sets. For a full set of options see: https://pypi.python.org/pypi/git-review
Gerrit documentation
The documentation for Gerrit is here: