Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Add --no-thin and refs/drafts/...

...

Submitting a patch to Gerrit is therefore exactly the same as 'pushing' a sequence of commits to a remote Git repository:

git push --no-thin asf-gerrit HEAD:refs/for/master

...

One thing to note is that Gerrit will submit all patches between the HEAD of the target branch and your current branch's HEAD for review. So:

git push --no-thin asf-gerrit HEAD:refs/for/master

... will push all commits between asf-gerrit/master and your HEAD. Please therefore make certain that you are only pushing the commits you want reviewed: every separate commit translates to an e-mail in everyone's inbox!

Testing your configuration

If you want to check that you set up gerrit correctly, you can

Code Block
git push --no-thin asf-gerrit HEAD:refs/drafts/master

This will push a patch that only you can see. When you see it has worked, you can click "Abandon" on it in the web interface.

Merging a patch (Impala committers only!)

...

  1. Create the branch in gerrit: https://gerrit.cloudera.org/#/admin/projects/Impala-ASF,branches
  2. Fetch the branch from gerrit and push it to the ASF Impala repository
Code Block
git fetch asf-gerrit
git checkout -b the-new-branch asf-gerrit/the-new-branch
git push apache HEAD:the-new-branch

 

Git and Gerrit etiquette

Contribution guidelines

...