Versions Compared

Old Version 17

changes.mady.by.user Lefty Leverenz

Saved on

compared with

New Version 18

changes.mady.by.user Siddharth Seth

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Patches should be rejected which do not adhere to the guidelines in HowToContribute. Committers should always be polite to contributors and try to instruct and encourage them to contribute better patches. If a committer wishes to improve an unacceptable patch, then it should first be rejected, and a new patch should be attached by the committer for review.

PreCommit runs, and committing patches

  1. Run Pre-Commit tests on a patch before committing
  2. If the test run is clean (and there's a +1 from a committer), the patch can be committed.
  3. Test runs may not be clean due to issues in the patch itself, or due to flaky tests
  4. If the failure is identified to be a flaky test, before committing, cite the JIRA which covers the flaky test (tracked under HIVE-15058). Create a new one if a JIRA does not already exist. 

      If a commit introduces new test failures, the preferred process is to revert the patch, rather than opening a new JIRA to fix the new failures.

Commit

When you commit a patch, please:

...