...
- Once ticket has passed all the reviews and has no additional comments, a committer should apply the latest patch to the master branch.
- A comment should be added to the ticket stating that the patch has been applied to master.
- Move ticket to
CLOSED
state.
Review With Upsource
Upsource is an online code review tool. It provides a convenient way to view and discuss changes.
Upsource is optional: it is up to author and reviewer whether to use it or not. Big changes with long discussions are easier to manage in Upsource.
- Register on http://reviews.ignite.apache.org/
- Go to Branches view: http://reviews.ignite.apache.org/ignite/branches
- Click on your pull request ("PR XXXX")
- Click "Create branch review"
- Rename review to include JIRA key and description (example: "IGNITE-42 Support CacheLoader and CacheWriter")
- In JIRA, use More -> Link -> Web Link to link the review page
...