Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: insert table of contents

Table of Contents

What is Gerrit?

The Impala project uses Gerrit for all our code reviews. Gerrit is a git-based code review tool. The Impala project Gerrit server is here.

...

Once your patch is cherry-picked by Impala Public Jenkins, a committer needs to push the commit to the Apache git repository, by running:

 

Code Block
bin/push_to_asf.py

push_to_asf.py checks the latest commits in gerrit and checks if they are in the Apache git repo. If some are not in the Apache git repo yet, it will ask you if you want to update the Apache git repo with the missing commits found in the Gerrit repo. It does not check what your local state is at all. It only compares remote Gerrit with the remote Apache repo. Keep in mind that if you are a committer, it will allow you to commit any change authored by anyone that has passed GVO.

...