Versions Compared

Old Version 2

changes.mady.by.user Unknown User (nazeer1100126)

Saved on

compared with

New Version 3

changes.mady.by.user Unknown User (nazeer1100126)

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • Make sure general java coding standards are practiced. If there is a better approach than implemented suggest the same on PR page
  • Make sure new files have ASF license text
  • Make sure there is no existing functionality failure by running integration tests
  • Make sure new integration tests are added with new functionality
  • Make sure there is no build failures with commits

PMD and Findbugs gradle plugins are integrated as part of Fineract build scripts. Currently these plugins are configured in such a way to ignore the failures until existing failures are resolved. Once existing issues are resolved, we will enable to fail the build in case of errors.