Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • The name "AlterAcls" suggests that ACLs are being altered.  However, in fact ACLs are only being added or removed, but not altered.
  • It's unclear what order the add and remove operations happen in.
  • It is unclear whether a remove operation can remove something added in the same AlterAcls request.
  • If add and remove operations are reordered, a security hole could be created when brokers are configured with default-allow behavior.  Deleting a restrictive ACL on a secure topic before adding a new restrictive ACL on that topic creates a window of vulnerability.
  • AddAcls and RemoveAcls is similar to the existing AddTopics and RemoveTopics APIs.
  public AclFilter ANY = new AclFilter();