Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • Attach a patch, pull request url or branch name (see instructions at Workflow)
  • (OPTIONAL) create an Upsource review: Review With Upsource
  • Add comment describing what has been implemented.
  • Move ticket to PATCH AVAILABLE state.If there is a community member who you think should do the review, optionally assign the ticket to that person
Info
titleOptional: Tips to pass review quickly

Ask commiter to review changes directly.


Check affected files git history to find person most likely able to review changes.

In case it's hard to determine who's able to review by git history use maintainers list presented above.


Add "review request" comment to the Jira Issue starting with a commiter username.

for example: "[~avinogradov], Please review my changes."


Commiter will gain notification and review your changes and/or help to find another commiter to do this.

Reviewing a Ticket

  • Each comment should be started with [~username] to guarantee proper notification.
  • Commiter should add comment like "Changes accepted and ready to be merged." once review successfully finished
  • Add review comments to a ticket.
  • Assign to the community member working on this ticket.
  • Once the comments have been addressed, the ticket should be submitted for review again.

Closing a Ticket

  • Once ticket has passed all the reviews and has no additional comments, a committer should apply the latest patch to the master branch.
  • A comment should be added to the ticket stating that the patch has been applied to master.
  • Move ticket to RESOLVED state. 

...