Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

It seems that naming LogCleaner is somewhat misleading and LogComparator is more appropriate one. So LogCleaner and related classes/methods/configs should be renamed to Comparator instead of Cleaner

Public Interfaces

log.cleaner.enable will be deprecated and eventually, it will be removed from the configuration. Going forward if log.cleanup.policy is set to compact then cleaner will be enabled implicitly.

 

Following old configuration will be deprecated and new renamed configuration will be introduced. 

log.compactor.enable
Existing configurationNew configuration

log.cleaner.enable

log.cleaner.backoff.mslog.compactor.backoff.ms
log.cleaner.dedupe.buffer.sizelog.compactor.dedupe.buffer.size
log.cleaner.delete.retention.mslog.compactor.delete.retention.ms
log.cleaner.io.buffer.load.factorlog.compactor.io.buffer.load.factor
log.cleaner.io.buffer.sizelog.compactor.io.buffer.size
log.cleaner.io.max.bytes.per.secondlog.compactor.io.max.bytes.per.second
log.cleaner.min.cleanable.ratiolog.compactor.min.cleanable.ratio
log.cleaner.min.compaction.lag.mslog.compactor.min.compaction.lag.ms
log.cleaner.threadslog.compactor.threads

...