Versions Compared

Old Version 16

changes.mady.by.user Jim Apple

Saved on

compared with

New Version 17

changes.mady.by.user Michael Brown

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: use HTTPS scheme and drop port 8080

...

To verify a patch, we use one of two different automated processes. Both are restricted to use by committers. If you are not a committer and your patch has been +2ed, please ask a committer to run the verification for you.

First, log in to httpto https://jenkins.impala.io:8080. If you are a committer and forgot your password, ask dev@impala.apache.org for help. Someone will reset your password.

Then, if your commit changes only files in the docs/ folder:

  1. Go to httphttps://jenkins.impala.io:8080/job/gerrit-docs-submit/build?delay=0sec. Put your gerrit patch URL in the PATCH_URL field. Leave the other fields with their default values. Press "Build".
  2. If all goes well, you will see messages like "Build started: httphttps://jenkins.impala.io:8080/job/gerrit-docs-submit/4/" and "Verified+1" and "Change has been successfully cherry-picked as 84ee40428dbb18146760adec8c5a03559f527ddb by Impala Public Jenkins" on your patch.
  3. If something breaks, go to the URL Jenkins posted to your patch. It will look something like this: httphttps://jenkins.impala.io:8080/job/gerrit-docs-submit/10/. Click on the "Build Artifact" and "Console Output" to look at the logs and figure out what went wrong.

If your commit doesn't change any files in the docs/ folder: 

  1. Go to httphttps://jenkins.impala.io:8080/job/gerrit-verify-dryrun/build?delay=0sec. Put your gerrit patch URL in the PATCH_URL field. Leave the other fields with their default values. Press "Build".
  2. If all goes well, you will see messages like "Build started: httphttps://jenkins.impala.io:8080/job/gerrit-verify-dryrun/151/" and "Verified+1" and "Change has been successfully cherry-picked as 84ee40428dbb18146760adec8c5a03559f527ddb by Impala Public Jenkins" on your patch.
  3. If something breaks, go to the URL Jenkins posted to your patch. It will look something like this: httphttps://jenkins.impala.io:8080/view/Gerrit/job/gerrit-verify-dryrun/141/. Click on the "Build Artifact" and "Console Output" to look at the logs and figure out what went wrong.

If your commit touches files both in and out of the docs/ folder, run httphttps://jenkins.impala.io:8080/job/gerrit-verify-dryrun/build?delay=0sec first, following the directions above. Once it succeeds, run httphttps://jenkins.impala.io:8080/job/gerrit-docs-submit/build?delay=0sec.

 

Tip

Verifying and cherry-picking a patch can be simplified with a bookmarklet. Here is how to do that in Chrome:

  1. Go to any webpage you like, say http://example.com.

  2. Press control-d.

  3. In the Folder drop down, select "Bookmarks Bar".

  4. If your bookmarks bar is not visible, press control-shift-b.

  5. If your new bookmark is not visible, click on the ">>" on the right-hand side of the bookmarks bar, then drag it to the visible part of the bar.

  6. Right-click on it and select "Edit".

  7. Change the name to "Jenkins code pre-commit" and the URL to javascript:location.href='httphttps://jenkins.impala.io:8080/job/gerrit-verify-dryrun/parambuild/?PATCH_URL='+encodeURIComponent(document.location.href);

  8. When you are ready to have Jenkins +Verify and cherry-pick a patch, go to the patch, ala https://gerrit.cloudera.org/#/c/5664/, then click your bookmarklet.

  9. Press Build.

By changing the javascript URL, you can also make a bookmarklet for the docs Jenkins job.

...