Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: mention non-committer methods of verification

...

This will push a patch that only you can see. When you see it has worked, you can click "Abandon" on it in the web interface.

Verifying a patch (open to all Impala contributors)

Note

The following does not apply if changes are only within the docs/ directory.

The following Jenkins jobs are available to all Impala contributors for testing patches they submit to Gerrit.

pre-review-test: Use this to compile Impala and run, if desired, tests or test subsets.

gerrit-verify-dryrun-external (WIP; coming soon): Use this to run the full set of verifications, including a compile of Impala, backend tests, frontend tests, core end-to-end tests, RAT verification, and more. This is a wrapper around what a committer will ultimately run for you to verify and submit. This omits the submission phase.

Verifying and submitting a patch (Impala committers only)

...

  1. Go to https://jenkins.impala.io/job/gerrit-docs-submit/build?delay=0sec. Put your gerrit patch URL in the PATCH_URL field. Leave the other fields with their default values. Press "Build".
  2. If all goes well, you will see messages like "Build started: https://jenkins.impala.io/job/gerrit-docs-submit/4/" and "Verified+1" and "Change has been successfully cherry-picked as 84ee40428dbb18146760adec8c5a03559f527ddb by Impala Public Jenkins" on your patch.
  3. If something breaks, go to the URL Jenkins posted to your patch. It will look something like this: https://jenkins.impala.io/job/gerrit-docs-submit/10/. Click on the "Build Artifact" and "Console Output" to look at the logs and figure out what went wrong.

...

  1. Go to https://jenkins.impala.io/job/gerrit-verify-dryrun/build?delay=0sec. Put your gerrit patch URL in the PATCH_URL field. Leave the other fields with their default values. Press "Build".
  2. If all goes well, you will see messages like "Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/151/" and "Verified+1" and "Change has been successfully cherry-picked as 84ee40428dbb18146760adec8c5a03559f527ddb by Impala Public Jenkins" on your patch.
  3. If something breaks, go to the URL Jenkins posted to your patch. It will look something like this: https://jenkins.impala.io/view/Gerrit/job/gerrit-verify-dryrun/141/. Click on the "Build Artifact" and "Console Output" to look at the logs and figure out what went wrong.

If your commit touches files both in and out of the docs/ folder, run https://jenkins.impala.io/job/gerrit-verify-dryrun/build?delay=0sec first, following the directions above. Once it succeeds, run https://jenkins.impala.io/job/gerrit-docs-submit/build?delay=0sec.

...