Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Make "publish" language a bit less scary

...

To send a patch for review, you should push it to a Gerrit-specific 'branch' on the Gerrit remote. That branch has the form refs/drafts/<branch-name> or refs/for/<branch-name>. Use the draft form to review the change yourself, or use the "for" form to publish the review to the community immediatelyThat patch will then be visible to code reviewers, who will review your code before it becomes part of Impala. If you want to see what a patch looks like without making it visible to code reviewers, push to the branch refs/drafts/<branch-name>. For the vast majority of patches the target branch will be master, which is where all mainline development happens. During releases, release managers may push commits to a specific release branch, however most new development will happen on master.

...

Visit the URL that Gerrit provided to review the diff before sending it out to reviewers. Check that you've uploaded the right commit and that you've included what you wanted in the diff. When you've reviewed it, hit the "Publish" button () to send the review to the community. This will make the review visible, but it won't be an official part of the Impala code base yet.

Note that Gerrit will send all patches between the HEAD of the target branch and your current branch's HEAD for review. Please therefore make certain that you are only pushing the commits you want reviewed: every separate commit translates to an e-mail in everyone's inbox!

...