Versions Compared

Old Version 8

changes.mady.by.user Matt Farmer

Saved on

compared with

New Version 9

changes.mady.by.user Matt Farmer

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Change log level on CONTINUE

...

We'll make a change to the onCompletion handler in RecordCollectorImpl to execute the handle method in its ProductionExceptionHandler and only record the exception in sendException if handle returns CONTINUE. We'll ensure that the RecordCollectorImpl always logs when it processes a response from a ProductionExceptionHandler - logging the current error message at ERROR level when instructed to FAIL and logging a comparable error message a WARN DEBUG level when instructed to CONTINUE. This ensures that it's not possible for a client developer to ship code that totally swallows errors without presenting any kind of activity in the log.

...