Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Added some details for the reviewer and committer workflows

...

This assumes you already have a copy of the repository (https://git-wip-us.apache.org/repos/asf/knox.git).

1. Make sure your code is up-to-date:

...

5. Create a patch, if desired. Note that commit messages should include the issue identifier and the issue title.

Code Block
git reset --soft origin/master
git commit -am "KNOX-nnn: <short, meaningful message>"
git format-patch origin/master --stdout > KNOX-nnn.patch

...

3. Implement the feature and commit and push as desired. Note that commit messages should include the issue identifier and the issue title.

Code Block
git commit -am "<short message about commit>"
git push

...

Code Block
languagebash
ant generate review

4. Create If you're only creating a patch.  First however you need to , then remove any changes to the generated site.  Those changes will be regenerated by the committer as part of committing the patch.  If you don't do this it makes it patch review process very difficult.  We recommend naming the patch using the JIRA ID.  Upload the patch to the JIRA and request review from a committer.

Code Block
svn revert --recursive site
svn diff > KNOX-nnn.patch

5. If you're committing changes, then DO NOT revert the generated site content. Commit all the changes.

Code Block
languagebash
svn ci <modified_files> -m "Change comment"

 

 

Include Page
Footer
Footer