Versions Compared

Old Version 6

changes.mady.by.user Bhavin Thaker

Saved on

compared with

New Version 7

changes.mady.by.user Meghna Baijal

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  
NoCategoryProblemSource FilesSuggested byLeadsComments
1.Source tree
* Move the various git submodules into third-party/ or similar so it's
simpler to see what is Apache original source when we review a release.
submodulesHenri Yandell  
2.Copyright
* Deal with the Copyright statements in perl-package (copyright holder has
approved doing this)
perl-packageHenri Yandell  
3.Formatting
* Lots of whitespace on end of NOTICE
NOTICEHenri Yandell Meghna PR in Review
4.Comments
* Comment added to CODEOWNERS to explain the file so we don't cause
community problems
CODEOWNERSHenri Yandell  
5.Licenses
* There was a suggestion to simplify the LICENSE to not explicitly list
which packages are under each license. Something to consider.
LICENSEHenri Yandell  
       
6.
Specific 
Files
* Resolve License - if you follow the URL mentioned in the file it is unclear 
if the code came form that site or was written for the project by the author 
of that site.

example/image-classification/predict-cpp/image-classification-predict.cc

Justin McClean   
7. 
Specific
   
       
Files
* Resolve License - This file has two license headers
tools/license_header.pyJustin McCleanMeghnaPossibly RAT got confused by the matching string
8.
Specific 
Files
* Check License - Listed as Apache License in the LICENSE but is it MIT license?
nnvm/tvm/HalideIR/LICENSE    
 9. 
Specific

  
Files
* Check License - Listed as Apache License in the LICENSE but is it MIT license?
example/rcnn/rcnn/cython/gpu_nms.pyx    
10. 
Specific

  
Files
* Check License - Listed as Apache License in the LICENSE but is it MIT license?
example/rcnn/rcnn/cython/gpu_nms.pyx    
11. 
Specific
  
Files
* Check License - Listed as Apache License in the LICENSE but is it MIT license?
example/rcnn/rcnn/cython/cpu_nms.pyx    
 12.