THIS IS A TEST INSTANCE. ALL YOUR CHANGES WILL BE LOST!!!!
...
D. Open Issues/Questions/Doubts/Concerns (Help Requested!)
...
Question 1: What all can be excluded from RAT checks? Currently the following are being excluded from the RAT checks. Is this ok ?
| Name of File/Folder Excluded from RAT Check | Reason for Ignoring | Concerns | |
|---|---|---|---|
| 1 | These File Types: *.xml ; *.css ; *.txt; *.md ; \..* ; *.ipynb ; *.html ; *.js ; *.json ; *.svg; *.config; *.names; *.csv | ||
| 2 | Submodules - 3rdparty/* ; dmlc-core/* ; mshadow/* ; dmlc-core/* ; dlpack/* ; nnvm/* ; ps-lite/* | None | |
| 3 | R-package | Not a part of MXNet Release | None |
| 4 | Ignore all Dockerfiles - docker/*; Dockerfile* ; docker_multiarch/* | Dockerfiles cant have license | |
| 5 | perl-package/* | I am not entirely sure about licensing here. (Also see issue 12 in the last table below) | I think I can add ASF header. |
| 6 | contrib/* | I am not entirely sure about licensing here. | Is ASF header ok? |
| 7 | __init__.py files | These files contain no text | None |
| 8 | docs/* | A header might affect website. | Can someone verify its ok to add ASF without impacting the website |
| 9 | This file - src/operator/nn/pool.h | It was decided that this file should not have an Apache License and it was removed here - PR 9170 | None. But can be verified again. |
| 10 | This file - src/operator/special_functions-inl.h | It was decided that this file should not have an Apache License and it was removed here - PR 9170 | None. But can be verified again. |
| 11 | example/rcnn/rcnn/cython/* | This is licensed under MIT but RAT doesnt pick that. ASF should not be added | Should MIT license text be added explicitly? |
| 12 | This Dataset - example/gluon/tree_lstm/dataset.cPickle | This is a dataset | None. But can be verified again. |
| 13 | This file - tools/coreml/pip_package/README.rst | This is a README | None. But can be verified again. |
...
Question 2: There are still 7 files with unknown licenses as per Apache RAT - SEE TABLE BELOW for this LIst
- This list assumes all 7 PRs listed above are approved and merged
This list assumes above excluded folders and formats are acceptable.
S.No File Name Comments 1. CODEOWNERS 2. appveyor.yml 3. readthedocs.yml 4. snap.python 5. snapcraft.yaml 6. python/mxnet/cython/base.pyi 7. tests/ci_build/pylintrc
...
Question 3: Issue 6 in table below
This file has had some conflict - example/image-classification/predict-cpp/image-classification-predict.cc
(and one more)
...
Question 4: Issue 23 and Issue 37 in table below
This Folder needs to be reviewed - src/operator/contrib/ctc_include
...