Versions Compared

Old Version 127

changes.mady.by.user Shanthoosh Venkataraman

Saved on

compared with

New Version 128

changes.mady.by.user Shanthoosh Venkataraman

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • Modify the existing interfaces and classes as per the proposed solution.

  • Add unit tests to test and validate compatibility and functional correctness. 

  • Add integration tests in samza standalone samples to verify the host affinity feature. 

  • Add an integration test to verify that there are minimal partition movements during rolling upgradesupgrade.

  • Verify compatibility - Jackson, a java serialization/deserialization library is used to convert data model objects in samza into JSON and back. After removing containerId field from ContainerModel, it should be verified that deserialization of old ContainerModel data with new ContainerModel spec works. 

  • Some TaskNameGrouper implementations assumes the comparability of integer containerId present in ContainerModel(for instance - GroupByContainerCount, a TaskNameGrouper implementation). Modify existing TaskNameGrouper implementations to take in collection of string processorId’s, as opposed to assuming that containerId is integer and lies within [0, N-1] interval(without incurring any change in functionality).

...