Versions Compared

Old Version 89

changes.mady.by.user Denis Magda

Saved on

compared with

New Version 90

changes.mady.by.user Dmitry Pavlov

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Recommendations for beginning work, review process

...

  • Anyone in the community can start working on any unassigned ticket. 
  • (OPTIONAL) It is recommended to clarify the relevance and correctness of the ticket in the community before doing actual implementation. To do this, you can write a letter to the dev.list and wait for answer.
  • Before beginning working on a ticket, you should assign the ticket to yourself.
  • Move the ticket to IN PROGRESS state.
  • If necessary, add comments describing the design decisions or approach you plan to take.

...

  • Each comment should be started with [~username] to guarantee proper notification.
  • Commiter should add comment like "Changes accepted and ready to be merged." once review successfully finished.
  • If the commiter/contributor has proposals, it is recommended to add a comment in the ticket in addition to PR / CR comments referring proposals added. This helps other committers to identify that fix has something to improve.

Closing a Ticket

  • Once ticket has passed all the reviews and has no additional comments, a committer should apply the latest patch to the master branch.
  • A comment should be added to the ticket stating that the patch has been applied to master.
  • Move ticket to RESOLVED state. 

...