Versions Compared

Old Version 91

changes.mady.by.user Dmitry Pavlov

Saved on

compared with

New Version 92

changes.mady.by.user Vladimir Ozerov Ozerov

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • Ignite employs both Review-Then-Commit (RTC) process for most of the components and Commit-Then-Review (CTR) for few ones.
  • Any change that touches code or test, whether reviewed or not, must have full TeamCity CI test suite pass.
  • As a guideline, trivial changes, like updates to documentation or tests, etc. should not need a review prior to committing, and often can be made directly in the master branchPlease consult to Review Checklist to understand how tickets are reviewed and what rules to follow.

Info
titleMaster Branch
 Ignite "master" branch should always be release-ready. Please avoid any commits or merges to the "master" branch unless the whole TeamCity CI suite has passed.

...

Info
titleOptional: Tips to pass review quickly

Ask commiter to review changes directly.


Check affected files git history to find person most likely able to review changes.

In case it's hard to determine who's able to review by git history use maintainers list presented above.


Add "review request" comment to the Jira Issue starting with a commiter username.

for example: "[~avinogradov], Please review my changes."


Commiter will gain notification and review your changes and/or help to find another commiter to do this.

Reviewing a Ticket

  • Make sure that your patch satisfies Review Checklist rules.
  • Each comment should be started with [~username] to guarantee proper notification.
  • Commiter should add comment like "Changes accepted and ready to be merged." once review successfully finished.
  • If the commiter/contributor has proposals, it is recommended to add a comment in the ticket in addition to PR / CR comments referring proposals added. This helps other committers to identify that fix has something to improve.

...