Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Generics "Gotchas"

Palette

The current (1.4-m2) Palette class' constructor signature looks like this:

Code Block

public Palette(String id, 
               IModel<Collection<T>> model,
	       IModel<Collection<? extends T>> choicesModel, 
               IChoiceRenderer<T> choiceRenderer, 
               int rows,
	       boolean allowOrder)

This doesn't allow me to use an IModel<List<T>>. How about if we change it to:

Code Block

public Palette(String id, 
               IModel<? extends Collection<T>> model,
	       IModel<? extends Collection<? extends T>> choicesModel, 
               IChoiceRenderer<T> choiceRenderer, 
               int rows,
	       boolean allowOrder)

This appears to make things nicer in my local if I change it.