Page History

...

• We wrap lines at 90 characters (instead of 80)
• We use 2 spaces indent (instead of 4)

We

...

automatically run flake8-diff on jobs pre-commit to report style violations on lines that patches modify. It is configured using setup.cfg in the Impala repository. You can run flake8 on a specific file with the impala-flake8 script:

# Works in an Impala development environment. Lists all violations for a file or subdirectory.
impala-flake8 <path to file>

# Show newly introduced violations for your current HEAD commit in git.
# Requires you to install flake8-diff separately.
flake8-diff HEAD^ HEAD

# Generate the same violations as the Impala jenkins bot for your current HEAD commit in git.
./bin/jenkins/critique-gerrit-review.py --dryrun

The following tools have also been found useful by developers to scan and/or automatically fix formatting issues:

...