Versions Compared

Old Version 4

changes.mady.by.user Tim Armstrong

Saved on

compared with

New Version 5

changes.mady.by.user Tim Armstrong

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

We automatically run flake8-diff on jobs pre-commit to report style violations on lines that patches modify. It is configured using setup.cfg in the Impala repository.

You can run flake8 on a specific file with the impala-flake8 script:in several ways. Note that a lot of existing Python code in Impala doesn't meet our current style standards. We fix such issues incrementally when we modify the code.

Code Block
languagebash
# Works in an Impala development environment. Lists all violations for a file or subdirectory.
impala-flake8 <path to file>

# Show newly introduced violations for your current HEAD commit in git.
# Requires you to install flake8-diff separately.
flake8-diff HEAD^ HEAD

# Generate the same violations as the Impala jenkins bot for your current HEAD commit in git.
./bin/jenkins/critique-gerrit-review.py --dryrun

...