Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

After you have made the necessary changes, please make sure that you re:

  • Re-compile MXNet if necessary

...

  • and verify the fix with the corresponding environment by running the same tests for more than 10000 passes (now can be done more easily with Automated Flaky Test Detector)

...

...

  • Have proper title for your PR and remember to refer to the tracking issue for the flaky test in your PR

...

  • Address any code review comments on your PR

...

After Fix is Merged

After you have addressed all comments on your PR it should be good for merge, once it's merged, make sure you also check if the related Github issue is closed so that we have accurate tracking. Flakiness may still exist even after a fix is delivered as 10000 trials may still not be enough to cover each and every single random seed, so please stay alerted for future occurrences.

...