This page is meant as a template for writing a KIP. To create a KIP choose Tools->Copy on this page and modify with your content and replace the heading with the next KIP number and a description of your issue. Replace anything in italics with your own descriptionKIP is aimed at improving the error-handling semantics in Kafka Streams when Kafka Steams fails to serialize a message to the downstream sink by providing an interface that can provide custom massaging of the error (e.g. report to a custom metrics system) and indicate to Streams whether or not it should re-throw the Exception, thus causing the application to fall over.

Status

Current state: "Under Discussion"

Discussion thread: here [Change the link from the KIP proposal email archive to your own email thread]

...

We are proposing addition of a new overloaded method in ProductionExceptionHandler interface, handle, that has the following signature:

        ProductionExceptionHandlerResponse handle(ProducerRecord record, boolean isKey, Exception exception)

Proposed Changes

Describe the new thing you want to do in appropriate detail. This may be fairly extensive and have large subsections of its own. Or it may be a few sentences. Use judgement based on the scope of the change.

Compatibility, Deprecation, and Migration Plan

• What impact (if any) will there be on existing users?
• If we are changing behavior how will we phase out the older behavior?
• If we need special migration tools, describe them here.
• When will we remove the existing behavior?

Rejected Alternatives

...

This implementation will add the overloaded method, handle, in the following two classes:

• DefaultProductionExceptionHandler and returns response as FAIL
• AlwaysProductionExceptionHandler and returns response as CONTINUE

We'll implement the following error handling logic to the send in RecordCollectorImpl. The overloaded method, handle, in ProductionExceptionHandler will be invoked when

1. ClassCastException is thrown while serializing record key / value. Today, we are throwing StreamsException on hitting this exception. Whether to throw the
   exception to the user will be decided based on the response received from ProductionExceptionHandler handle method. 
   1. If the result is CONTINUE, log a note at DEBUG that we received that result and are not failing Streams as a result.
   2. If the result is FAIL, log a message at ERROR that we received that result and throw StreamsException so Streams will fail.
2. Any other unchecked exceptions, that thrown during record key / value serialization.
   1. If the result is CONTINUE, log a note at DEBUG that we received that result and are not failing Streams as a result.
   2. If the result is FAIL, log a message at ERROR that we received that result and set sendException so Streams will fail.

Earlier, we are invoking the error handler only when there are any exceptions in producer callback. Now, we also invoke the handler when hitting the serialization exception. As explained in KIP-210, this will facilitate a number of error handling scenarios.  

Compatibility, Deprecation, and Migration Plan

The default behavior will be consistent with the existing behavior. The new overloaded method, handle, will have a implementation that is set to FAIL by default.

Rejected Alternatives

We have considered to reuse the existing handle(ProducerRecord<byte[], byte[]> record, Exception exception) method in ProductionExceptionHandler, but it has following limitation:

1. The parameter ProducerRecord key and value type is set to byte[], on hitting the serialization exception the record key and value type may not be byte[].
2. To explicitly tell the user that the serialization exception occurred when serializing the record key or value.