Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Current tag set : network processor id only


Proposed Initially proposed tag set : security protocol, listener name, network processor id


Eventually implemented tag set:  listener name, network processor id

Image Added

Compatibility, Deprecation, and Migration Plan

  • What impact (if any) will there be on existing users?
    Users currently using reporters that do not support metric tags and flatten the tags map into the metrics name, will find that the name has changed
  • The Yammer metric "IdlePercent" should remain not tagged with listener, for compatibility; It's an alias to the Kafka metric "io-wait-ratio" that gets tagged 
  • The socket-server-metrics.* are not exposed as Yammer metrics which are still the most commonly consumed server-side metrics, so the impact of this change is mitigated (thanks Ismael Juma Juma)

Rejected Alternatives

1) Having both listener and securityProtocol tags, in favor of having just the listener, as this reduces clutter
And in most simple cases, the two tags could end up having the same value

Proposed tag set : security protocol, listener name, network processor id

Image Added

 

2) The listener tag could be omitted if it is the same as the protocol one :

...