Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Table of Contents

Status

Current state"Adopted"

Discussion thread: here [Change the link from the KIP proposal email archive to your own email thread]

...

Please keep the discussion on the mailing list rather than commenting on the wiki (wiki discussions get unwieldy fast).

Motivation

Currently, per-network-processor-thread metrics, like socket-server-metrics.connection-count,  socket-server-metrics.connection-close-rate etc are tagged with networkProcessor:<id> where the id of a network processor is just a numeric integer.

...

This KIP is co-authored with Mickael Maison

Public Interfaces

  • Monitoring

The metrics in the socket-server-metrics group  will gain two new entries in their tags map, Security Protocol name and the Listener name

Proposed Changes

Example representation of the metrics in JConsole :

...

Eventually implemented tag set: listener name, network processor id

Compatibility, Deprecation, and Migration Plan

  • What impact (if any) will there be on existing users?
    Users currently using reporters that do not support metric tags and flatten the tags map into the metrics name, will find that the name has changed
  • The Yammer metric "IdlePercent" should remain not tagged with listener, for compatibility; It's an alias to the Kafka metric "io-wait-ratio" that gets tagged 
  • The socket-server-metrics.* are not exposed as Yammer metrics which are still the most commonly consumed server-side metrics, so the impact of this change is mitigated (thanks Ismael Juma Juma)

Rejected Alternatives

1) Having both listener and securityProtocol tags, in favor of having just the listener, as this reduces clutter
And in most simple cases, the two tags could end up having the same value

...