Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Table of Contents


Status

Current state: Under Discussion

Discussion thread: here  

JIRAKafka-14768

Motivation

Sometimes, application's threads will block for max.block.ms to send records using KafkaProducer#send. It exhausted threads of whole system for the time in some cases.

...

What's more, the metadata's fetch only need to be done one time in whole blocking of KafkaProducer#send. After the complete of first fetch, the metadata will be retrieved from cache directly and its timer update only happen on network thread instead of user's thread.

So, this KIP try to reach the goal we can change reduce the blocking time by changing the max.block.ms to wanted smaller value without worry worrying about the metadata's fetch. 

Public Interfaces

No public interface changed. Just change the inner implement of private method:

...

Add two new configure items for producer.

Proposed Changes

The changes can refer to the example PR:  https://github.com/apache/kafka/pull/13335/files

...

When user set includeWaitTimeOnMetadataInMaxBlockTime to false, KafkaProducer#send will block maxWaitTimeMsOnMetadata for metadata's fetch and block max.block.ms for remaining operations.

Compatibility, Deprecation, and Migration Plan

If user want to use the feature, user can upgrade the client with the new configures set.

...

  • What impact (if any) will there be on existing users?  
    no impact on existed users.
  • If we are changing behavior how will we phase out the older behavior?
    no changing older behavior.
  • If we need special migration tools, describe them here.
    no.
  • When will we remove the existing behavior?
    no need to remove.

Test Plan


We can test with test matrix:

...

Case 2 and case 5 will fail to send records. All of others are success.

Rejected Alternatives

Alternative 1:

Provide new method to complete the metadata fetch not controlled by max.block.ms and user should call it before sending any record. For example, user can call it before marking the service ready.

...