Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Please refer to How to Contribute for instructions how to submit a code review to http://reviews.apache.orgto Github.

What makes a good code review?

...

We have a global community of committers, so please be mindful that you should wait at least 24 hours before pushing merging your patch pull request even though you may already have the necessary +1.
This encourages others to take an interest in your review pull request and helps us find more bugs (it's ok to slow down in order to speed up).

Always include the "Ambari" group in the code review and  at least two committers that are familiar with that code area.
If you want to subscribe to code reviews for a particular area, feel free to edit this section.

AreaExample FilesReviewers (reviewboard id)
Ambari AlertsAlert*.java
alert_*.py 
jhurley
Ambari Agent/ambari-agent/* 
Ambari Metrics System/ambari-metrics/*swagle, avijayan
Ambari Views/ambari-views/* 
Ambari Server
(threads, caching, lifecycle) 
/ambari-server/*swagle, ncole, jhurley, afernandez
Ambari REST API
(/api/v?/....) 

*Service.java
*ResourceDefinition.java
*ResourceHandler.java

rlevas, dili, jluniya
Ambari Infra/ambari-infra/*oleewere
Blueprints Blueprint*.javarnettleton
LogSearch/ambari-logsearch/* 

oleewere, miki.gergely

Rolling & Express Upgrade

*upgrade.xml
config-upgrade.xml
hdp select, conf select 

afernandez, ncole, jhurley, dmitriusan,

dili, tthorpe

Security, Kerberos, LDAPjava files and kerberos.jsonrlevas
Stack Advisorstack_advisor.pysrimanth, tthorpe
Stack Frameworkmetainfo.xml, any config filesjluniya, tthorpe, jmarron, swapan, mradha25
UI/ambari-web/*yusaku, rzang, jwang
 Mpack  
Services:
Accumulo  
Atlas afernandez
Falcon  
Flume  
Hawq  
HBase avijayan
HDFS afernandez
Hive  
Kafka  
Knox afernandez
Logsearch  
Mahout  
Oozie  
Pig  
PXF  
Ranger  
Slider  
Spark  
Sqoop  
Storm afernandez
Tez  
YARN  
Zeppelin  
Zookeeper  

...

setupMpacks.py

Mpack*.java

Registry*.java

jluniya, swapan, mradha25, thorpe