Page History

This page explains how to use Phabricator for code review of contributions to Apache Hive.

Setup

1. Visit https://reviews.facebook.net and connect your existing github or Facebook account there.
2. The Phabricator command-line tool arc requires a PHP interpreter available on your development machine.  If you can run the command php --version, you already have it.  If not, google for "php command line" to see how to install it for your system.
3. Next, install arc, but instead of getting unstable trunk versions, get stable versions of arcanist and libphutil via
   • git clone git://github.com/jsichi/libphutil.git
   • git clone git://github.com/jsichi/arcanist.git
   . If you follow the Arcanist Quick Start guide, only the first section ("Install Arcanist") is applicable.
4. Run ant arc-setup to install an extra module needed for JIRA integration.  (This ant target was added with the commit of HIVE-2486.)
5. In your Hive checkout (either git or svn), run arc install-certificate and follow the instructions given.

...

If you just want to see what your diff looks like, without actually creating it, use --preview to the arc diff command line (but don't proceed with creating the diff when you visit it in the UI since it will be missing the JIRA information).

Updating Patches (git)

At this point, reviewers can add comments and request changes.  To address them:

...

From an svn checkout (e.g. from svn checkout http://svn.apache.org/repos/asf/hive/trunk^{Image Removed} hive-trunk), a typical usage sequence is as follows:

...

If you just want to see what your diff looks like, without actually creating it, omit --jira on the arc diff command line.  (The svn workflow does not support the --preview option.)

Updating Patches (svn)

At this point, reviewers can add comments and request changes.  To address them:

...

4. "Reviewers: JIRA" - if you remove JIRA from reviewers, comments and patches
won't be propagated to JIRA.

FAQs

1. If you run into an error like the following on arc:

libphutil v1 libraries are no longer supported

git checkout this particular tag in your libphutil repository:

git checkout 870bcc76434410344d27a3fa4604ac96200bf7f6

2. If you run into an error like this with Arcanist:

Call to undefined method ArcanistGitAPI parseRelativeLocalCommit()
  OR
Failed to load symbol ...

Checkout this tag for arcanist:

git checkout 6f6fde84cc530c2b51f095d9636b9e15301519a1