THIS IS A TEST INSTANCE. ALL YOUR CHANGES WILL BE LOST!!!!
| Table of Contents |
|---|
Status
Current state: Under DiscussionAccepted
Discussion thread: here
JIRA: here
...
| method | Added for this KIP ? | Object/method used for node name | Used for repartition topic name | Used for state store name ? | |
|---|---|---|---|---|---|
| filter(Predicate, Named) | YES | static Named#as(String) | N/A | N/A | |
| filterNot(Predicate, Named) | YES | static Named#as(String) | N/A | N/A | |
| selectKey(KeyValueMapper, Named) | YES | static Named#as(String) | N/A | N/A | |
| map(KeyValueMapper, Named) | YES | static Named#as(String) | N/A | N/A | |
| mapValues(ValueMapper, Named) | YES | static Named#as(String) | N/A | N/A | |
| mapValues(ValueMapperWithKey, Named) | YES | static Named#as(String) | N/A | N/A | |
| flatMap(KeyValueMapper, Named) | YES | static Named#as(String) | N/A | N/A | |
| flatMapValues(ValueMapper, Named) | YES | static Named#as(String) | N/A | N/A | |
| flatMapValues(ValueMapperWithKey, Named) | YES | static Named#as(String) | N/A | N/A | |
| print(Printed) | NO | static Printed#as(String) | N/A | N/A | |
| foreach(ForeachAction, Named) | YES | static Named#as(String) | N/A | N/A | |
| peek(ForeachAction, Named) | YES | static Named#as(String) | N/A | N/A | |
| branch(Named, Predicate...) | YES | static Named#as(String) | N/A | N/A | |
| through(String, Produced) | NO | static Produced#as(String) | N/A | N/A | |
| to(String, Produced) | NO | static Produced#as(String) | N/A | N/A | |
| to(TopicNameExtractor, Produced) | NO | static Produced#as(String) | N/A | N/A | |
| transform(TransformerSupplier, Named, String... ) | YES | static Named#as(String) | N/A | N/A | |
| transformValues(ValueTransformerSupplier, Named, String...) | YES | static Named#as(String) | N/A | N/A | |
| transformValues( ValueTransformerWithKeySupplier, Named, String...) | YES | static Named#as(String) | N/A | N/A | |
| process(ProcessorSupplier, Named, String...) | YES | static Named#as(String) | N/A | N/A | |
| join( KStream, ValueJoiner, JoinWindows windows, Joined) | NO | static Joined#namedJoined#as(final String name) | static Joined#namedJoined#as(final String name) | static Joined#namedJoined#as(final String name) | |
| leftJoin(KStream, ValueJoiner, JoinWindows, Joined) | NO | static Joined#namedJoined#as(final String name) | static Joined#namedJoined#as(final String name) | static Joined#namedJoined#as(final String name) | |
| outerJoin(KStream, ValueJoiner, JoinWindows, Joined) | NO | static Joined#namedJoined#as(final String name) | static Joined#namedJoined#as(final String name) | static Joined#namedJoined#as(final String name) | |
| join(KTable, ValueJoiner, Joined) | NO | static Joined#namedJoined#as(final String name) | static Joined#namedJoined#as(final String name) | N/A | |
| leftJoin(KTable, ValueJoiner, Joined) | NO | static Joined#namedJoined#as(final String name) | static Joined#namedJoined#as(final String name) | N/A | |
| join(GlobalKTbale, KeyValueMapper, ValueJoiner, Named) | NOYES | static Named#as(PREFIX + COUNTString) | N/A | N/A | |
| joinleftJoin(GlobalKTbaleGlobalKTable, KeyValueMapper, ValueJoiner, Named) | YES | static Joined#namedNamed#as(final String name) | N/A | N/A | |
| leftJoinflatTransform(GlobalKTableTransformerSupplier, KeyValueMapper, ValueJoinerNamed named, String... stateStoreNames) | NO | YES | static Named#as(String) | N/A | N/A |
| flatTransformValues(ValueTransformerWithKeySupplier, Named, String... ) | YES | static Named#as(String(PREFIX + COUNT) | N/A | N/A | |
| leftJoinflatTransformValues(GlobalKTableValueTransformerSupplier, KeyValueMapper, ValueJoinerNamed, String...) | YES | static Joined#namedNamed#as(final String name) | N/A | N/A |
KTable (16 new methods)
| method | Added for this KIP ? | Object/method used for node name | Used for repartition topic name | Used for state store name ? |
|---|---|---|---|---|
| filter(Predicate, Named) | YES | static Named#as(String) | N/A | (PREFIX + COUNT) |
| filter(Predicate, Named, Materialized) | YES | static Named#as(String) | N/A | Materialized#as(String) |
| filterNot(Predicate, Named) | YES | static Named#as(String) | N/A | (PREFIX + COUNT) |
| filterNot(Predicate, Named, Materialized) | YES | static Named#as(String) | N/A | Materialized#as(String) |
| mapValues(ValueMapper, Named) | YES | static Named#as(String) | N/A | (PREFIX + COUNT) |
| mapValues(ValueMapperWithKey, Named) | YES | static Named#as(String) | N/A | (PREFIX + COUNT) |
| mapValues(ValueMapper, Named, Materialized) | YES | static Named#as(String) | N/A | static Materialized#as(String) |
| mapValues(ValueMapperWithKey, Named, Materialized); | YES | static Named#as(String) | N/A | static Materialized#as(String) |
| suppress(Suppressed) | NO | Suppressed#withName(String) | N/A | N/A |
| transformValues(ValueTransformerWithKeySupplier, Named, String...) | YES | static Named#as(String) | N/A | (PREFIX + COUNT) |
| transformValues(ValueTransformerWithKeySupplier, Materialized, Named, String...) | YES | static Named#as(String) | N/A | static Materialized#as(String) |
| groupBy(KeyValueMapper, KeyValue, Grouped) | NO | static Grouped#as(String) | static Grouped#as(String) | N/A |
| join(KTable, ValueJoiner, Named) | YES | static Named#as(String) | N/A | (PREFIX + COUNT) |
| join(KTable, ValueJoiner, Named, Materialized) | YES | static Named#as(String) | N/A | static Materialized#as(String) |
| leftJoin(KTable, ValueJoiner, Named); | YES | static Named#as(String) | N/A | (PREFIX + COUNT) |
| leftJoin(KTable, ValueJoiner, Named, Materialized) | YES | static Named#as(String) | N/A | static Materialized#as(String) |
| outerJoin(KTable, ValueJoiner, Named); | YES | static Named#as(String) | N/A | (PREFIX + COUNT) |
| outerJoin(KTable, ValueJoiner, Named, Materialized) | YES | static Named#as(String) | N/A | static Materialized#as(String) |
...
| toStream( |
...
| Named) | YES | static Named#as(String) | N/A | N/A |
| toStream(KeyValueMapper, Named) | YES | static Named#as(String) | N/A | N/A |
KGroupedStream (6 new methods)
| method | Added for this | method | Added for this KIP ? | Object/method used for node name | Used for repartition topic name | Used for state store name ? |
|---|---|---|---|---|---|---|
| count(Named) | YES | static Named#as(String) | N/A | (PREFIX + COUNT) | ||
| count(Named, Materialized) | YES | static Named#as(String) | N/A | Materialized#as(String) | ||
| reduce(Reducer, Named) | YES | static Named#as(String) | N/A | (PREFIX + COUNT) | ||
| reduce(Reducer, Named, Materialized) | YES | static Named#as(String) | N/A | Materialized#as(String) | ||
| aggregate(Initializer, Aggregator, Named) | YES | static Named#as(String) | N/A | (PREFIX + COUNT) | ||
| aggregate(Initializer, Aggregator, Named, Materialized) | YES | static Named#as(String) | N/A | Materialized#as(String) |
...
The main reason why we propose to overload each method accepting a Materialized argument is to not introduce ambitguity by conflating config objects that configure an operation (like Grouped, Joined) with config objects that configure an aspect of the operation (like Materialized).
Proposed Changes
Name Validation
User provided node name should follow the same restrictions that ones currently apply to state stores during the create of Materialized instance.
Currently, the Materialized class relies on the static method Topic#validate. This method ensure that a provided name only contains legal characters [a-zA-Z0-9._-] and have a maximum length of 249.
We propose to copy methods from Topic#validate into Named. This new method will be used validate both store names and node names. The benefit is to remove a dependency with the core module.
In addition, the Materialized class will throw a TopologyException while building the topology in case of a unvalid name instead of InvalidTopicException .
Proposed Changes
- Implement the new interface NamedOperation and Implement the new interface NamedOperation and default class Named
- Update all parameter class to implement NamedOperation : Produced Consumed Printed Joined Grouped Suppressed
- Overload methods stateless for classes KStreams, KTables, KGroupedStream, KGroupedTable, TimeWindowedKStream, TimeWindowedKTable
- The processor names specified by developer will be used in place of the static processor prefix. Statics prefixes will still be used if no custom processor name are specified.
- Processor names should follow the same restrictions as the topic names. So legal characters are [a-zA-Z0-9._-] and the maximum length us of 249.
Below is an application example :
...