Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • Do all automated continuous integration checks pass?
  • Is the update a patch, minor, or major update?
    • Major updates need more stringent review criteria than the other updates, at least a manual reading of the library's release notes / changelog to check for API changes.
  • Is the license still compatible with ASF License Policy?
  • Have any changes been made to LICENSE/NOTICE files that need to be incorporated? 
    • Note that something as simple as a date change in a LICENSE/NOTICE file requires an update.
  • Have any transitive dependencies been added or changed?
    • If so, we must perform all the same checks above for those dependenies as well.

Making Updates

If changes are needed, such as updates to allow the integration tests to pass or to update a LICENSE/NOTICE file, the following steps can be performed:

  1. Add the Scala Steward daffodil fork as a new remote:

    Code Block
    git remote add scala-steward git@github.com:scala-steward-org/daffodil.git


  2. Fetch the branch associated with the new depenencydependency:

    Code Block
    git fetch scala-steward update/jackson-core-2.11.4


  3. Checkout the branch:

    Code Block
    git checkout update/jackson-core-2.11.4


  4. Commit any necessary changes to this branch.
       
  5. Push changes back to the scala-steward remote:

    Code Block
    git push scala-steward udpateupdate/jackson-core-2.11.4


  6. Follow the Code Contributor Workflow just as usual, eventually squashing changes, and using push --force  to  to push those changes back to the scala-steward remote to update pull request before being merged.