Page History

This document describes how to commit changes to ZooKeeperAmbari. It assumes a knowledge of subversionGit. While it is for committers to use as a guide, it also provides contributors an idea of how the commit process actually works.

In general we are very conservative about changing the Apache Ambari code base. It is ground truth for systems that use it, so we need to make sure that it is reliable. For this reason we use Review Then Commit (RTC) http://www.apache.org/foundation/glossary.html#ReviewThenCommit^{Image Removed} change policy.

...

A committer must sign off on a patch. It is very helpful if the community also reviews the patch, but in the end a committer must take responsibility for the correctness of the patch. If the match patch is simple enough and the committer feels confident in the review, a single +1 from a committer is sufficient to commit the patch. (Remember committers cannot review their own patch, so if . If a committer submits a patch, they should make sure that another committer reviews it.)

With the required number of approvals, a committer (any committer can do this including the one that committed the patch) can now make the change to the code base. Here are the recommended steps for committing:

• make sure the code is up-to-date
• svn update

• apply the patch
• patch -p0 < path_to_patch

• run the tests are your machine as a final check.

...

Follow the instructions in How to Contribute guide to commit changes to Ambari.

If the Jira is a bug fix you may also need to commit the patch to the latest branch in

...

Add Labelsgit (trunk).