Versions Compared

Old Version 2

changes.mady.by.user Ken Huang

Saved on

compared with

New Version Current

changes.mady.by.user Ken Huang

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  1. We will add a deprecated annotation on `RemoteStorageMetrics#REMOTE_LOG_READER_TASK_QUEUE_SIZE_METRIC` and `RemoteStorageMetrics#REMOTE_LOG_READER_AVG_IDLE_PERCENT_METRIC`
  2. Update the Kafka documentation to note MBean will be replaced
    1. org.apache.kafka.storage.internals.log:type=RemoteStorageThreadPool.RemoteLogReaderTaskQueueSize
    2. org.apache.kafka.storage.internals.log:type=RemoteStorageThreadPool.RemoteLogReaderAvgIdlePercent
  3. Register new metrics `kafka.log.remote:type=RemoteStorageThreadPool.RemoteLogReaderTaskQueueSize` and `kafka.log.remote:type=RemoteStorageThreadPool.RemoteLogReaderAvgIdlePercent` into `RemoteStorageThreadPool#metricsGroup`
  4. Delete`RemoteStorageMetrics#REMOTE_LOG_READER_TASK_QUEUE_SIZE_METRIC` and `RemoteStorageMetrics#REMOTE_LOG_READER_AVG_IDLE_PERCENT_METRIC all usage in code base.

Test Plan

  • Add new tests to verify the new metric is correctly registered and behaves as expected.
  • Ensure backward compatibility by verifying deprecated metric behavior until removal.

Rejected Alternatives

n/a