Versions Compared

Old Version 2

changes.mady.by.user Lefty Leverenz

Saved on

compared with

New Version Current

changes.mady.by.user Szehon Ho

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Made some clarifications in discussion with Lefty

Whereas the TestCliDriver tests run all tests under /clientpositive and /clientnegative respectively, the MiniDriver tests (i.e., TestMiniTezCliDriver, TestMinimrCliDriver) run only a subset of those for time reasons.  These are determined by a properties file located in ./itests/qtest/testconfiguration.properties.

Currently there are the following properties:

  • minimr.query.files:  Tests run by TestMinimrCliDriver (positive)

  • minimr.query.negative.files:  Tests run by TestMinimrCliDriver (negative)

  • minitez.query.files.shared: Tests run by TestMinimrCliDriver and TestMiniTezCliDriver

  • minitez.query.files: Tests run by TestMiniTezCliDriver

  • beeline.positive.exclude: Tests excluded when running with TestBeeLineDriver, if it's enabled.

Thus, be sure to update this properties file if adding/removing a test from any of these test drivers.

As this list may change, check ./itests/qtest/pom.xml for what each driver uses.  In particular, 'includeQueryFiles' and 'excludeQueryFiles' for each driver will refer to one or more of these properties.

The Hive PTest2 Infrastructure running Hive Pre Commit Tests does not use ./itests/qtest/pom.xml but has similar logic to parse this property file, in short because it needs to create different test batches for each node.  If changing the driver definitions themselves (say modifying the property key, adding a new driver), please keep in mind Ptest2 Infra in addition to the pom.xml would need to understand the new changes as well

The Hive build (non-ptest2) uses properties (in the pom.xml) to describe which .q files should be run with minimr versus the normal test runner. All of these .q files exist in the same directory. Therefore without parsing the pom.xml (or build.xml before it) PTest2 has no way to identify which tests should be run via minimr.

At present we do not parse the pom.xml to obtain the list and instead maintain a separate list. The fallout is that when a new minimr test is created, it must added to the properties file for precommit to run it. See Hive PTest2 Infrastructure for the host and path of the properties file to edit.