THIS IS A TEST INSTANCE. ALL YOUR CHANGES WILL BE LOST!!!!
...
git submodule update --init
git checkout -b quickstep-101
git add some-changed-or-new-files
- Then test your changes doing at least the following:
Check if your code confirms to the code guidelines by running the following command from the root of the quickstep source directory:
python third_party/cpplint/lint_everything.py
- Check for CMake validation errors by running the following command from the root of the quickstep source directory:
python validate_cmakelists.py
- Check for cyclic dependencies by running the following command from the root of the quickstep source directory:
python
cyclic_dependency.py
- From the build directory, run all the tests using the command: ctest -j8-j`sysctl -n hw.ncpu`
- If you have made changes to the parser to add new tokens and/or grammar rules, please run the script
parser/genfiles.sh
and check the generated files into the directoryparser/preprocessed
. git commit -m "QUICKSTEP-101: Added My Awesome Feature."
git push origin quickstep-101
...
git remote add asf-mirror git@github.com:apache/incubator-quickstep.git
git remove -v
git fetch asf-mirror master
git rebase -i asf-mirror/master
- In the editor, you should see something like:
pick QUICKSTEP-101: Added My Awesome Feature.
pick Addressed Review Comments.
- While still in the editor, modify the second line to the following.
f Addressed Review Comments.
- Check the git log using:
git log.
- Check the "Author" field in the last commit with the intended name and email. Amend if needed.
- Now you are ready to push the code. You can do that using:
git push origin quickstep-101 -f
Create a Pull Request (PR) for the new feature
Use the GitHub ASF mirror repo: https://github.com/apache/incubator-quickstep, and set the title to, in this case, QUICKSTEP-101: Added My Awesome Feature
.
Committers will merge the PR under Code Review Guidelines.