Status

Current state: AcceptedUnder Discussion

Discussion thread: here

JIRA: KAFKA-1660, KAFKA-1659

Released: 0.8.3

Please keep the discussion on the mailing list rather than commenting on the wiki (wiki discussions get unwieldy fast).

...

• The close(timeout) should work when called from a user caller thread or the internal sender thread.
• In sender thread only close(0, TimeUnit.MILLISECONDS) should be called because:
  
  • close() should not be called because that will make producer block forever.
  • close(500, TimeUnit.MILLISECONDS) has the same effect as close(0, TimeUnit.MILLISECONDS) only except it will block for 500 milliseconds.
• IMPORTANT, for the reason above, if a close() or close(timeout, TimeUnit) is called from sender thread (i.e. callback). An error message will be logged and close(0, TimeUnit.MILLISECONDS) will be called instead.
• Because it is possible the close(timeout) is called for multiple times, it has to be idempotent.

...

When close(positive, TimeUnit.MILLISECONDS) is called, it will try to do a normal close first. If the normal close did not finish before timeout, it then close the producer forcefully. It will also wait the sender thread to finish.

...

If sender thread user calls close() in callback, it will block forever because the sender thread will try to join itself. So if a close() call is called from sender thread, an error message will be put in the log and sender thread will be blocked forever. This is to:

...

close(0) will be called instead.

Compatibility, Deprecation, and Migration Plan

...