Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Table of Contents

Status

Current state"under discussionaccepted"

Discussion threadHERE

JIRAKAFKA-4218, KAFKA-4726, KAFKA-3745KAFKA-7842KAFKA-7843

Please keep the discussion on the mailing list rather than commenting on the wiki (wiki discussions get unwieldy fast).

The PR can be found here.

Motivation

(taken from JIRA descriptions) 


 

  • Key access to ValueTransformer:  While transforming values via KStream.transformValues and ValueTransformer, the key associated with the value may be needed, even if it is not changed. For instance, it may be used to access stores.

    As of now, the key is not available within these methods and interfaces, leading to the use of KStream.transform and Transformer, and the unnecessary creation of new KeyValue objects.

  • Key access to ValueMapperValueMapper should have read-only access to the key for the value it is mapping. Sometimes the value transformation will depend on the key.

    It is possible to do this with a full blown KeyValueMapper but that loses the promise that you won't change the key – so you might introduce a re-keying phase that is totally unnecessary.

  • Key access to ValueJoiner interface: In working with Kafka Stream joining, it's sometimes the case that a join key is not actually present in the values of the joins themselves (if, for example, a previous transform generated an ephemeral join key.) In such cases, the actual key of the join is not available in the ValueJoiner implementation to be used to construct the final joined value. This can be worked around by explicitly threading the join key into the value if needed, but it seems like extending the interface to pass the join key along as well would be helpful

 Additionally we consider adding key access to Initializer and Reducer interfaces.

Public Changes

  • KStream interface:

Code Block
languagejava
<GK, GV, RV> KStream<K, RV> leftJoin(final GlobalKTable<GK, GV> globalKTable,
                                     final KeyValueMapper<? super K, ? super V, ? extends GK> keyValueMapper,
                                     final ValueJoinerWithKey<? super K, ? super V, ? super GV, ? extends RV> valueJoinerWithKey);

<GK, GV, RV> KStream<K, RV> join(final GlobalKTable<GK, GV> globalKTable,
                                 final KeyValueMapper<? super K, ? super V, ? extends GK> keyValueMapper,
                                 final ValueJoinerWithKey<? super K, ? super V, ? super GV, ? extends RV> valueJoinerWithKey);
 
<VT, VR> KStream<K, VR> leftJoin(final KTable<K, VT> table,
                                 final ValueJoinerWithKey<? super K, ? super V, ? super VT, ? extends VR> valueJoinerWithKey,
                                 final Serde<K> keySerde,
                                 final Serde<V> valSerde);

<VT, VR> KStream<K, VR> leftJoin(final KTable<K, VT> table,
                                 final ValueJoinerWithKey<? super K, ? super V, ? super VT, ? extends VR> valueJoinerWithKey);

<VT, VR> KStream<K, VR> join(final KTable<K, VT> table,
                             final ValueJoinerWithKey<? super K, ? super V, ? super VT, ? extends VR> valueJoinerWithKey,
                             final Serde<K> keySerde,
                             final Serde<V> valSerde);

<VT, VR> KStream<K, VR> join(final KTable<K, VT> table,
                             final ValueJoinerWithKey<? super K, ? super V, ? super VT, ? extends VR> valueJoinerWithKey);

<VO, VR> KStream<K, VR> outerJoin(final KStream<K, VO> otherStream,
                                  final ValueJoinerWithKey<? super K, ? super V, ? super VO, ? extends VR> valueJoinerWithKey,
                                  final JoinWindows windows,
                                  final Serde<K> keySerde,
                                  final Serde<V> thisValueSerde,
                                  final Serde<VO> otherValueSerde);

<VO, VR> KStream<K, VR> outerJoin(final KStream<K, VO> otherStream,
                                  final ValueJoinerWithKey<? super K, ? super V, ? super VO, ? extends VR> valueJoinerWithKey,
                                  final JoinWindows windows);

 
<VO, VR> KStream<K, VR> leftJoin(final KStream<K, VO> otherStream,
                                 final ValueJoinerWithKey<? super K, ? super V, ? super VO, ? extends VR> valueJoinerWithKey,
                                 final JoinWindows windows,
                                 final Serde<K> keySerde,
                                 final Serde<V> thisValSerde,
                                 final Serde<VO> otherValueSerde);

<VO, VR> KStream<K, VR> leftJoin(final KStream<K, VO> otherStream,
                                 final ValueJoinerWithKey<? super K, ? super V, ? super VO, ? extends VR> valueJoinerWithKey,
                                 final JoinWindows windows);

<VO, VR> KStream<K, VR> join(final KStream<K, VO> otherStream,
                             final ValueJoinerWithKey<? super K, ? super V, ? super VO, ? extends VR> valueJoinerWithKey,
                             final JoinWindows windows,
                             final Serde<K> keySerde,
                             final Serde<V> thisValueSerde,
                             final Serde<VO> otherValueSerde);

<VO, VR> KStream<K, VR> join(final KStream<K, VO> otherStream,
                             final ValueJoinerWithKey<? super K, ? super V, ? super VO, ? extends VR> valueJoinerWithKey,
                             final JoinWindows windows);

<VR> KStream<K, VR> transformValues(final ValueTransformerWithKeySupplier<? super K, ? super V, ? extends VR> valueTransformerWithKeySupplier,
                                    final String... stateStoreNames);

<VR> KStream<K, VR> mapValues(ValueMapperWithKey<? super K, ? super V, ? extends VR> mapperWithKey);
 

 
 
  • KTable interface:

 
Code Block
 
language
 
java
Proposed Changes

 

  • Handling lambdas

For Initializer, Aggregator, ValueMapper, ValueJoiner and their "withKey"  interfaces we support lambdas. For ValueTransformer interface we don't need lambdas by the core definition of the class. 

For all above interfaces we support rich functions. 

To support lambdas, we separate withKey interface from original ones, meaning we don't inherit or extend from one to another. 

 

  • RichValueMapper
Code Block
languagejava
public interface RichValueMapper<K, V, VR>  implements ValueMapperWithKey<K, V, VR>, RichFunction {
} 

public interface ValueMapperWithKey<K, V, VR> {
    VR apply(final K key, final V value);
}

public interface RichFunction {
    void init();
    void close();
}

 

 

  • RichValueJoiner
Code Block
languagejava
public interface RichValueJoiner<K, V1, V2, VR>  extends ValueJoinerWithKey<K, V1, V2, VR>, RichFunction {
}
 
public interface ValueJoinerWithKey<K, V1, V2, VR> {
    VR apply(final K key, final V1 value1, final V2 value2);
}
 

 

  • RichInitializer
Code Block
languagejava
public interface RichInitializer<VA> extends Initializer<VA>, RichFunction {
}
 

 

  • RichAggregator
Code Block
languagejava
public interface RichAggregator<K, V, VA> extends Aggregator<K, V, VA>, RichFunction {
}

 

  • ValueTransformerWithKeySupplier
Code Block
languagejava
public interface ValueTransformerWithKeySupplier<K, V, VR> {
    ValueTransformerWithKey<K, V, VR> get();
}

 

 

  • Handling rich functions while building the topology

 

In general, we change the constructors of all related backend Processors to be Rich types as we can easily convert lambdas/withKey-lambdas to Rich functions. 

 

  • RichValueMapper
Code Block
languagejava
@Override public <V1> KStream<K, V1> mapValues(final ValueMapperWithKey<? super K, ? super V, ? extends V1> mapperWithKey) { Objects.requireNonNull(mapperWithKey, "mapperWithKey can't be null"); String name = topology.newName(MAPVALUES_NAME); final RichValueMapper<K, V, V1> richValueMapper; if (mapperWithKey instanceof RichValueMapper) {
titleKTable interface
<VO, VR> KTable<K, VR> join(final KTable<K, VO> other,
                            final ValueJoinerWithKey<? super K, ? super V, ? super VO, ? extends VR> joiner);

<VO, VR> KTable<K, VR> join(final KTable<K, VO> other,
                            final ValueJoinerWithKey<? super K, ? super V, ? super VO, ? extends VR> joiner,
                            final Materialized<K, VR, KeyValueStore<Bytes, byte[]>> materialized);                                

<VO, VR> KTable<K, VR> join(final KTable<K, VO> other,
                  
richValueMapper
 
=
 
(RichValueMapper<K,
 
V,
 
V1>)
 
mapperWithKey;
    
}
 
else
final 
{
ValueJoinerWithKey<? super K, ? super V, ? super 
richValueMapper
VO, 
=
? 
new
extends VR> 
RichValueMapper<K
joiner,
 
V,
  
V1>()
 
{
            
@Override
            
public
final 
void
Named 
init() {}
named);

<VO, VR> KTable<K, VR> join(final KTable<K, VO> other,
     
@Override
            
public
 
void
 
close()
 
{}
        final ValueJoinerWithKey<? super K, 
@Override
? super V, ? super VO, ? extends VR> joiner,
   
public
 
V1
 
apply(K
 
key,
 
V
 
value)
 
{
                
return mapperWithKey.apply(key, value);
   final Named named,
             
}
        
};
    
}
   final 
topology.addProcessor(name
Materialized<K, 
new KStreamMapValues<>(richValueMapper), this.name); return new KStreamImpl<>(topology, name, sourceNodes, this.repartitionRequired); }

 

  • RichValueJoiner
Code Block
languagejava
static <K, T1, T2, R> ValueJoinerWithKey<K, T1, T2, R> convertToValueJoinerWithKey(final ValueJoiner<T1, T2, R> valueJoiner) { Objects.requireNonNull(valueJoiner, "valueJoiner can't be null"); return new ValueJoinerWithKey<K, T1, T2, R>() {
VR, KeyValueStore<Bytes, byte[]>> materialized);

<VR, KO, VO> KTable<K, VR> join(final KTable<KO, VO> other,
                                final Function<V, KO> foreignKeyExtractor,
             
@Override
        
public
 
R
 
apply(K
 
key,
 
T1
 
value1,
 
T2
 
value2) {
    final ValueJoinerWithKey<KO, V, VO, VR> joiner);                  
return
 
valueJoiner.apply(value1,
 
value2);
        
}
    
};

}

public <V1
<VR, KO, 
R>
VO> 
KStream<K
KTable<K, 
R>
VR> 
leftJoin
join(
final 
KStream<K
KTable<KO, 
V1>
VO> other,
    
final
 
ValueJoiner<?
 
super
 
V,
 
?
 
super
 
V1,
 
?
 
extends
 
R>
 
joiner,
    
final
 
JoinWindows
 
windows,
    
final
 
Serde<K> keySerde,
  
final
 
Serde<V>
 
thisValSerde,
   
final 
Serde<V1>
Function<V, 
otherValueSerde)
KO> 
{
foreignKeyExtractor,
    
return
 
doJoin(other,
        
convertToValueJoinerWithKey(joiner),
   
//
 
doJoin
 
and
 
join
 
methods
 
accept
 
ValueJoinerWithKey
 
type
 
and
 
corresponding
 
Processors
 
accept
 
only
 
Rich
 
functions
 
in
 
their constructor. windows,
final ValueJoinerWithKey<KO, V, VO, VR> joiner,
         
keySerde,
        
thisValSerde,
        
otherValueSerde,
       final 
new KStreamImplJoin(true, false)
Materialized<K, VR, KeyValueStore<Bytes, byte[]>> materialized);
}

 

 

  • Converters between Rich/WithoutKey/WithKey types
Code Block
languagejava
static <K, T1, T2, R> RichValueJoiner<K, T1, T2, R> convertToRichValueJoiner(final ValueJoinerWithKey<K, T1, T2, R> valueJoinerWithKey) { Objects.requireNonNull(valueJoinerWithKey, "valueJoiner can't be null"); if (valueJoinerWithKey instanceof RichValueJoiner) {

<VR, KO, VO> KTable<K, VR> join(final KTable<KO, VO> other,
                              
return
 
(RichValueJoiner<K,
 
T1,
final 
T2
Function<V, 
R>) valueJoinerWithKey;
KO> foreignKeyExtractor,
    
}
 
else
 
{
        
return
 
new
 
RichValueJoiner<K,
 
T1,
 
T2,
 
R>()
 
{
            
@Override
final ValueJoinerWithKey<KO, V, VO, VR> joiner,
       
public
 
void
 
init()
 
{}
            
@Override
          final 
public void close() {}
Named named);

<VR, KO, VO> KTable<K, VR> join(final KTable<KO, VO> other,
      
@Override
                          final Function<V, KO> foreignKeyExtractor,
                                final ValueJoinerWithKey<KO, 
public
V, VO, VR> joiner,
                                final Named named,
                                final Materialized<K, VR, KeyValueStore<Bytes, byte[]>> materialized);


<VO, VR> KTable<K, VR> leftJoin(final KTable<K, VO> other,
                                final ValueJoinerWithKey<? super K, ? super V, ? super VO, ? extends VR> joiner);

<VO, VR> KTable<K, VR> leftJoin(final KTable<K, VO> other,
                                final ValueJoinerWithKey<? super K, ? super V, ? super VO, ? extends VR> joiner,
                                final Materialized<K, VR, KeyValueStore<Bytes, byte[]>> materialized);                                

<VO, VR> KTable<K, VR> leftJoin(final KTable<K, VO> other,
                                final ValueJoinerWithKey<? super K, ? super V, ? super VO, ? extends VR> joiner,
                                final Named named);

<VO, VR> KTable<K, VR> leftJoin(final KTable<K, VO> other,
                                final ValueJoinerWithKey<? super K, ? super V, ? super VO, ? extends VR> joiner,
                                final Named named,
                                final Materialized<K, VR, KeyValueStore<Bytes, byte[]>> materialized);

<VR, KO, VO> KTable<K, VR> leftJoin(final KTable<KO, VO> other,
                                    final Function<V, KO> foreignKeyExtractor,
                                    final ValueJoinerWithKey<KO, V, VO, VR> joiner);                                

<VR, KO, VO> KTable<K, VR> leftJoin(final KTable<KO, VO> other,
		                            final Function<V, KO> foreignKeyExtractor,
		                            final ValueJoinerWithKey<KO, V, VO, VR> joiner,
		                            final Materialized<K, VR, KeyValueStore<Bytes, byte[]>> materialized);

<VR, KO, VO> KTable<K, VR> leftJoin(final KTable<KO, VO> other,
	                                final Function<V, KO> foreignKeyExtractor,
	                                final ValueJoinerWithKey<KO, V, VO, VR> joiner,
	                                final Named named);

<VR, KO, VO> KTable<K, VR> join(final KTable<KO, VO> other,
                                final Function<V, KO> foreignKeyExtractor,
                                final ValueJoinerWithKey<KO, V, VO, VR> joiner,
                                final Named named,
                                final Materialized<K, VR, KeyValueStore<Bytes, byte[]>> materialized);





    • KGroupedStream interface:

Code Block
languagejava
KTable<K, V> reduce(final ReducerWithKey<K, V> reducerWithKey);
 
KTable<K, V> reduce(final ReducerWithKey<K, V> reducerWithKey,
                    final String queryableStoreName);
 
KTable<K, V> reduce(final ReducerWithKey<K, V> reducerWithKey,
                    final StateStoreSupplier<KeyValueStore> storeSupplier);
 
<W extends Window> KTable<Windowed<K>, V> reduce(final ReducerWithKey<K, V> reducerWithKey,
                                                 final Windows<W> windows,
                                                 final String queryableStoreName);
<W extends Window> KTable<Windowed<K>, V> reduce(final Reducer<V> reducer,
                                                 final Windows<W> windows);
 
<W extends Window> KTable<Windowed<K>, V> reduce(final ReducerWithKey<K, V> reducerWithKey,
                                                 final Windows<W> windows,
                                                 final StateStoreSupplier<WindowStore> storeSupplier);
 
KTable<Windowed<K>, V> reduce(final ReducerWithKey<K, V> reducerWithKey,
                              final SessionWindows sessionWindows,
                              final String queryableStoreName);
 
KTable<Windowed<K>, V> reduce(final ReducerWithKey<K, V> reducerWithKey,
                              final SessionWindows sessionWindows);
 
KTable<Windowed<K>, V> reduce(final ReducerWithKey<K, V> reducerWithKey,
                              final SessionWindows sessionWindows,
                              final StateStoreSupplier<SessionStore> storeSupplier);
 
 
 
 
<VR> KTable<K, VR> aggregate(final InitializerWithKey<K, VR> initializerWithKey,
                             final Aggregator<? super K, ? super V, VR> aggregator,
                             final Serde<VR> aggValueSerde,
                             final String queryableStoreName);
 
<VR> KTable<K, VR> aggregate(final InitializerWithKey<K, VR> initializerWithKey,
                             final Aggregator<? super K, ? super V, VR> aggregator,
                             final Serde<VR> aggValueSerde);
 
<VR> KTable<K, VR> aggregate(final InitializerWithKey<K, VR> initializerWithKey,
                             final Aggregator<? super K, ? super V, VR> aggregator,
                             final StateStoreSupplier<KeyValueStore> storeSupplier);
 
<W extends Window, VR> KTable<Windowed<K>, VR> aggregate(final InitializerWithKey<K, VR> initializerWithKey,
                                                         final Aggregator<? super K, ? super V, VR> aggregator,
                                                         final Windows<W> windows,
                                                         final Serde<VR> aggValueSerde,
                                                         final String queryableStoreName);
 
<W extends Window, VR> KTable<Windowed<K>, VR> aggregate(final InitializerWithKey<K, VR> initializerWithKey,
                                                         final Aggregator<? super K, ? super V, VR> aggregator,
                                                         final Windows<W> windows,
                                                         final Serde<VR> aggValueSerde);
 
<W extends Window, VR> KTable<Windowed<K>, VR> aggregate(final InitializerWithKey<K, VR> initializerWithKey,
                                                         final Aggregator<? super K, ? super V, VR> aggregator,
                                                         final Windows<W> windows,
                                                         final StateStoreSupplier<WindowStore> storeSupplier);
 
 
 
<T> KTable<Windowed<K>, T> aggregate(final InitializerWithKey<K, VR> initializerWithKey,
                                     final Aggregator<? super K, ? super V, T> aggregator,
                                     final Merger<? super K, T> sessionMerger,
                                     final SessionWindows sessionWindows,
                                     final Serde<T> aggValueSerde,
                                     final String queryableStoreName);
 
 
<T> KTable<Windowed<K>, T> aggregate(final InitializerWithKey<K, VR> initializerWithKey,
                                     final Aggregator<? super K, ? super V, T> aggregator,
                                     final Merger<? super K, T> sessionMerger,
                                     final SessionWindows sessionWindows,
                                     final Serde<T> aggValueSerde);
 
 
<T> KTable<Windowed<K>, T> aggregate(final Initializer<T> initializer,
                                     final Aggregator<? super K, ? super V, T> aggregator,
                                     final Merger<? super K, T> sessionMerger,
                                     final SessionWindows sessionWindows,
                                     final Serde<T> aggValueSerde,
                                     final StateStoreSupplier<SessionStore> storeSupplier);


Proposed Changes


  • Handling lambdas

For  ValueMapper, ValueJoiner and their "withKey"  interfaces we support lambdas. For ValueTransformer interface we don't need lambdas by the core definition of the class. 

To support lambdas, we separate withKey interface from original ones, meaning we don't inherit or extend from one to another. 


  • ValueMapperWithKey
    Code Block
    languagejava
    public interface ValueMapperWithKey<K, V, VR> {
        VR apply(final K readOnlyKey, final V value);
    }


  • ValueJoinerWithKey
    Code Block
    languagejava
    public interface ValueJoinerWithKey<K, V1, V2, VR> {
        VR apply(final K readOnlyKey, final V1 value1, final V2 value2);
    }


  • ValueTransformerWithKeySupplier
    Code Block
    languagejava
    public interface ValueTransformerWithKeySupplier<K, V, VR> {
        ValueTransformerWithKey<K, V, VR> get();
    }
     
    public interface ValueTransformerWithKey<K, V, VR> {
    	void init(final ProcessorContext context);
        VR transform(final K readOnlyKey, final V value);
        void close();
    }


  • ReducerWithKey

    Code Block
    languagejava
    public interface ReducerWithKey<K, V> {
    	V apply(final K readOnlyKey, final V value1, final V value2);
    }


  • InitializerWithKey

    Code Block
    languagejava
    public interface InitializerWithKey<K, VA> {
    	VA apply(final K readOnlyKey);
    }


Handling withKey interfaces while building the topology


In general, we change the constructors of all related backend Processors to be withKey types as we can easily convert regular (withoutKey) interfaces to withKey interfaces.


  • ValueMapperWithKey
Code Block
languagejava
@Override
public <V1> KStream<K, V1> mapValues(final ValueMapper< ? super V, ? extends V1> mapper) {
    Objects.requireNonNull(mapperWithKey, "mapperWithKey can't be null");
    String name = topology.newName(MAPVALUES_NAME);
    final ValueMapperWithKey<K, V, V1> valueMapperWithKey = new ValueMapperWithKey<K, V, V1>R apply(K key, T1 value1, T2 value2) {
                return valueJoinerWithKey.apply(key, value1, value2);
            }
        };
    }
}

static <K, T1, T2, R> ValueJoinerWithKey<K, T1, T2, R> convertToValueJoinerWithKey(final ValueJoiner<T1, T2, R> valueJoiner) {
    Objects.requireNonNull(valueJoiner, "valueJoiner can't be null");
    return new ValueJoinerWithKey<K, T1, T2, R>() {
        @Override
        public R apply(K key, T1 value1, T2 value2) {
            return valueJoiner.apply(value1, value2);
        }
    };
}

static <VA> RichInitializer<VA> checkAndMaybeConvertToRichInitializer(final Initializer<VA> initializer) {
    Objects.requireNonNull(initializer, "initializer can't be null");
    if (initializer instanceof RichInitializer) {
        return (RichInitializer<VA>) initializer;
    } else {
        return new RichInitializer<VA>() {
            @Override
            public VA apply() {
                return initializer.apply();@Override
            }

public V1 apply(K key, V value) {
      @Override
            public void init() {}
return mapper(value);
            @Override}
        };
    }
    public void close() {}topology.addProcessor(name, new KStreamMapValues<>(valueMapperWithKey), this.name);
    return new KStreamImpl<>(topology, name,  }sourceNodes, this.repartitionRequired);
    }
}



  • ValueJoinerWithKey
Code Block
languagejava
static <K, V, VA> RichAggregator<K, V, VA> checkAndMaybeConvertToRichAggregatorT1, T2, R> ValueJoinerWithKey<K, T1, T2, R> convertToValueJoinerWithKey(final Aggregator<KValueJoiner<T1, VT2, VA>R> aggregatorvalueJoiner) {
    Objects.requireNonNull(aggregatorvalueJoiner, "aggregatorvalueJoiner can't be null");
    return new if (aggregator instanceof RichAggregatorValueJoinerWithKey<K, T1, T2, R>() {
        return (RichAggregator<K, V, VA>) aggregator;@Override
        public R apply(K key, T1 value1, T2 value2) {
    } else {
      return  return new RichAggregator<K, V, VA>() {
valueJoiner.apply(value1, value2);
        }
    };
}


public <V1, R> KStream<K, R> @OverrideleftJoin(
    final KStream<K, V1> other,
    final publicValueJoiner<? VA apply(K key, V value, VA aggregate) {super V, ? super V1, ? extends R> joiner,
    final JoinWindows windows,
    final Serde<K> keySerde,
    return aggregator.apply(key, value, aggregate);final Serde<V> thisValSerde,
    final Serde<V1> otherValueSerde) {

    return }doJoin(other,

            @Override
convertToValueJoinerWithKey(joiner),   // doJoin, join methods, and corresponding Processors accept ValueJoinerWithKey type.
 public void init() {}

    windows,
        @OverridekeySerde,
        thisValSerde,
     public void close() {} otherValueSerde,
        };
    }new KStreamImplJoin(true, false));
}

 

The PR can be found here.



Test Plan

The unit tests are changed accordingly to support the changes in core classes. 


Rejected Alternatives

 


  • Lambdas are not supported


This document is proposed with ValueMapper example but it can be applied to other interfaces as well. Rich functions are proposed:
public interface RichFunction {
void init(final ProcessorContext context);

void close();
}
public abstract class AbstractRichFunction implements RichFunction {
@Override
  public void init(final ProcessorContext context) {}

@Override
  public void close() {}
}

 


public abstract class RichValueJoiner<K, V1, V2, VR> extends AbstractRichFunction implements ValueJoiner<V1, V2, VR>  {
@Override
  public final VR apply(final V1 value1, final V2 value2) {
return apply(null, value1, value2);
  }

public abstract VR apply(final K key, final V1 value1, final V2 value2);
}

 


Inside processor, we check if the instance (for example ValueMapper instance) is rich (for example RichValueMapper):

 


KStreamFlatMapValues(ValueMapper<? super V, ? extends Iterable<? extends V1>> mapper) {
this.mapper = mapper;
  isRichFunction = mapper instanceof RichValueMapper ? true : false;
}
@Override
public void process(K key, V value) {
Iterable<? extends V1> newValues;
if (isRichFunction) {
newValues = ((RichValueMapper<? super K, ? super V, ? extends Iterable<? extends V1>>) mapper).apply(key, value);
  } else {
newValues = mapper.apply(value);
 }
for (V1 v : newValues) {
context().forward(key, v);
  }
}
 



  • Not backward-compatible

 


We propose adding key information for ValueJoiner,  ValueTransformer, and ValueMapper classes and their apply(...) methods.

As a result, we perform the following public changes (and their overloaded versions)

ClassOldNew
KStream<VR> KStream<K, VR> mapValues(ValueMapper<? super V, ? extends VR> mapper); <VR> KStream<K, VR> mapValues(ValueMapper<? super K, ? super V, ? extends VR> mapper);
KStream<VR> KStream<K, VR> transformValues(final ValueTransformerSupplier<? super V, ? extends VR> valueTransformerSupplier, final String... stateStoreNames);<VR> KStream<K, VR> transformValues(final ValueTransformerSupplier<? super K, ? super V, ? extends VR> valueTransformerSupplier,final String... stateStoreNames);
KStream

<VO, VR> KStream<K, VR> join(final KStream<K, VO> otherStream,

 final ValueJoiner<? super V, ? super VO, ? extends VR> joiner,

final JoinWindows windows);

<VO, VR> KStream<K, VR> join(final KStream<K, VO> otherStream,

final ValueJoiner<? super K, ? super V, ? super VO, ? extends VR> joiner,

final JoinWindows windows);

KTable

<VR> KTable<K, VR> mapValues(final ValueMapper<? super V, ? extends VR> mapper);

<VR> KTable<K, VR> mapValues(final ValueMapper<? super K, ? super V, ? extends VR> mapper);
KTable

<VO, VR> KTable<K, VR> join(final KTable<K, VO> other, final ValueJoiner<? super V, ? super VO, ? extends VR> joiner);

<VO, VR> KTable<K, VR> join(final KTable<K, VO> other, final ValueJoiner<? super K, ? super V, ? super VO, ? extends VR> joiner);

 

 



  • Lacking performance because deep-copy and need for RichFunctions

 


  1. We extend the target interfaces ValueJoiner,  ValueTransformer, and ValueMapper as ValueJoinerWithKey,  ValueTransformerWithKey, and ValueMapperWithKey. In extended abstract classes we have an access to keys.
  2. In Processor we check the actual instance of object:
     
    this.valueTransformer = valueTransformer;
    if (valueTransformer instanceof ValueTransformerWithKey) {
    isTransformerWithKey = true;
    } else {
    isTransformerWithKey = false;
    }

    ..............

    ..............

    @Override
    public void process(K key, V value) {
    if (isTransformerWithKey) {
    K keyCopy = (K) Utils.deepCopy(key);
      context.forward(key, ((ValueTransformerWithKey<K, V, R>) valueTransformer).transform(keyCopy, value));
      } else {
    context.forward(key, valueTransformer.transform(value));
      }
    }

  3. As we can see from the above code snippet, we can guard the key change in Processors by deeply copying the object before calling the apply() method.

...