THIS IS A TEST INSTANCE. ALL YOUR CHANGES WILL BE LOST!!!!
...
The primary responsibility of the committers is to commit patches from various contributors. In order to do so, a committer do the followingshould follow these guidelines:
- Review the patch: Follow the How to Contribute guide's section on reviewing code to ensure that you review the code before committing it. Every patch that is committed to the source control must be reviewed by at least one committer first. If you are not ready to accept the patch in the current state, make sure you update the JIRA to 'Cancel Patch'.
- Make sure patch is attached to the JIRA with license grant: Before a patch is committed to the source code, the contributor must explicitly attach the patch to the JIRA and grant it the necessary licence for inclusion in Apache works.
- Commit the patch: If the patch meets review expectations and is well tested, it can be committed to the source control. Make sure that the patch applies cleanly to the latest revision and if not, request the patch be rebased accordingly. Once ready for commit, the commit message should have the following format:
Code Block SQOOP-XXX. Brief description of the problem. (Contributor's Name via Committer's Name) {qote} * *Mark the JIRA resolved:* After the patch has been committed, you should mark the JIRA resolved and ensure that it's {{fixVersion}} is set to the next release version number. Make sure to thank the contributor in the comment you add while marking the JIRA resolved. JIRA resolved/closed. h2. Contributing patches Committers can contribute patches on their own but should not commit them directly. As outlined in the [How to Contribute] guide, a committer should go through the same exercise of creating the patch, submitting it for review and ensuring that it is attached to the JIRA. Once your patch is reviewed by another committer, that committer will follow the steps outlined above in the 'Committing patches' section to commit your patch and close the associated JIRA. The only exception to this is when other committers are not available and you are the only active committer. In which case, Sqoop's voted policy is to wait for 2+3 days before committing. The full stated policy is as follows: {quote} Subject: \[VOTE\]\[RESULT\] Review and Commit Policy From: Arvind Prabhakar
- Mark the JIRA resolved: After the patch has been committed, you should mark the JIRA resolved and ensure that it's
fixVersionis set to the next release version number. Make sure to thank the contributor in the comment you add while marking the JIRA resolved.
Contributing patches
Committers can contribute patches on their own but should not commit them directly. As outlined in the How to Contribute guide, a committer should go through the same exercise of creating the patch, submitting it for review and ensuring that it is attached to the JIRA.
Once your patch is reviewed by another committer, that committer will follow the steps outlined above in the 'Committing patches' section to commit your patch and close the associated JIRA.
The only exception to this is when other committers are not available and you are the only active committer. In which case, Sqoop's voted policy is to wait for 2+3 days before committing. The full stated policy is as follows:
Subject: [VOTE][RESULT] Review and Commit Policy
From: Arvind Prabhakar (arv...@apache.org)
...
Date:
...
Aug
...
22,
...
2011
...
9:53:34
...
am
...
List:
...
org.apache.incubator.sqoop-dev
...
The
...
vote
...
for
...
Review
...
and
...
Commit
...
Policy
...
is
...
now
...
closed.
...
The
...
proposal
...
voted
...
for
...
is:
...
—
- The committer attaches the patch s/he
...
- would
...
- like
...
- to
...
- submit
...
- to
...
- the
...
JIRA
...
- and
...
- posts
...
- a
...
- code
...
- review
...
- requests
...
- with
...
- at
...
- least
...
- one
...
- other
...
committer
...
- identified
...
- as
...
- the
...
- reviewer.
...
- If
...
- the
...
- reviewer
...
- does
...
- not
...
- respond
...
- in
...
- two
...
- days
...
- time,
...
- the
...
- committer
...
sends
...
- a
...
- note
...
- to
...
- sqoop-dev@
...
- asking
...
- for
...
- the
...
- reviewer
...
- to
...
- prioritize
...
- the
...
review
...
- or
...
- for
...
- any
...
- other
...
- committer
...
- to
...
- volunteer
...
- for
...
- the
...
- review.
...
- If
...
- the
...
- review
...
- is
...
- still
...
- not
...
- done
...
- in
...
- the
...
- next
...
- three
...
- days,
...
- the
...
- change
...
may
...
- be
...
- committed
...
- and
...
- the
...
- JIRA
...
- resolved/closed.
...
- If
...
- the
...
- review
...
- is
...
- started,
...
- then
...
- no
...
- timeout
...
- applies
...
- and
...
- the
...
- full
...
review
...
- cycle
...
- should
...
- be
...
- followed
...
- until
...
- a
...
- reasonable
...
- version
...
- of
...
- the
...
change
...
- has
...
- been
...
- accepted.
...
- At
...
- which
...
- point
...
- it
...
- can
...
- be
...
- committed
...
- and
...
- the
...
JIRA
...
- resolved/closed.
...
The
...
DISCUSSION
...
thread
...
for
...
this
...
topic
...
can
...
be
...
found
...
at
...
[1
...
].
...
The
...
VOTE
...
thread
...
for
...
this
...
topic
...
can
...
be
...
found
...
at
...
[2
...
].
...
—Result:
...
The
...
proposal
...
passes
...
with
...
the
...
following
...
votes:
...
3
...
+1
...
votes:
...
Ahmed,
...
Mohammad,
...
Jonathan
...
0
...
+0
...
votes
...
0
...
-1
...
votes
...
Relevant
...
threads:
...
[1
...
]
...
...
[2
...
]
...
...
Thanks,
...
Arvind
...
Source: Original Mail