THIS IS A TEST INSTANCE. ALL YOUR CHANGES WILL BE LOST!!!!
Please refer to How to Contribute for instructions how to submit a code review to http://reviews.apache.orgto Github.
What makes a good code review?
...
We have a global community of committers, so please be mindful that you should wait at least 24 hours before pushing merging your patch pull request even though you may already have the necessary +1.
This encourages others to take an interest in your review pull request and helps us find more bugs (it's ok to slow down in order to speed up).
Always include the "Ambari" group in the code review and at least two committers that are familiar with that code area.
If you want to subscribe to code reviews for a particular area, feel free to edit this section.
| Area | Example Files | Reviewers (reviewboard id) | |
|---|---|---|---|
| Ambari Alerts | Alert*.java alert_*.py | jhurley | |
| Ambari Agent | /ambari-agent/* | ||
| Ambari Metrics System | /ambari-metrics/* | swagle, avijayan | |
| Ambari Views | /ambari-views/* | ||
| Ambari Server (threads, caching, lifecycle) | /ambari-server/* | swagle, ncole, jhurley, afernandez | |
| Ambari REST API (/api/v?/....) | *Service.java | ||
| Blueprints | rnettleton | ||
*ResourceDefinition.java | rlevas, dili, jluniya | ||
| Ambari Infra | /ambari-infra/* | oleewere | |
| Blueprints | Blueprint*.java | rnettleton | |
| LogSearch | /ambari-logsearch/* | oleewere, miki.gergely | |
| Rolling & Express Upgrade | *upgrade.xml | afernandez, ncole, jhurley, dmitriusan | |
| Ambari Metrics System | /ambari-metrics/* | swagle | |
, dili, tthorpe | |||
| Security, Kerberos, LDAP | Security and Kerberosjava files and kerberos.json | rlevas | |
| Stack | DefinitionAdvisor | stack_advisor.py | srimanth, tthorpe |
| Stack Framework | metainfo.xml, any config files | jluniya | |
| Stack Advisor | stack_advisor.py | srimanth | |
| , tthorpe, jmarron, swapan, mradha25 | |||
| UI | /ambari-web/* | yusaku, rzang, jwang | |
| Ambari Views | /ambari-views/* | ||
| ... |
...
| Mpack | setupMpacks.py Mpack*.java Registry*.java | jluniya, swapan, mradha25, thorpe |