Status

Current state:  ["Under Discussion"] Accepted

Discussion thread: hereTBD

JIRA:

...

• Purge repartition data on commit: this is summarized in 

  Jira
  server ASF JIRA serverId 5aa69414-a9e9-3523-82ec-879b028fb15b key KAFKA-6150

  . The AdminClient's deleteRecords API (adding in KIP-204) will be used upon committing intervals.
• Create internal topic within InternalTopicManager: we will use the create topic API to do that, and also weof AdminClient.
• We'll also remove the endless-loop checking after the creation within StreamsPartitionAssignor, StreamPartitionAssignor (

  Jira
  server ASF JIRA serverId 5aa69414-a9e9-3523-82ec-879b028fb15b key KAFKA-6126

  ); instead after the rebalance we will let the restoration retry within the main loop if the metadata is not known yet.
• We'll add an ADMIN_PREFIX (String contant valued "admin.") in the StreamsConfig for admin client usage which will allow certain config parameters for the admin client only, also add the adminClientPrefix function; this is similar to PRODUCER_PREFIX and CONSUMER_PREFIX.
• Compatibility check: we will use a network client for this purpose, as it is a one-time thing. remove this functionality and defer to the runtime to detect the returned error code and throw exception.

In addition, the following new public APIs will be added as part of this KIP (details of these changes can be found in https://github.com/apache/kafka/pull/4315):

• Overloaded KafkaStreams constructor to allow overriding the `Time` object.
• Overloaded AbstractConfig#originalsWithPrefix() to allow specifying whether or not to strip the prefix in the key of the returned map.

Regarding the changes to replace StreamsKafkaClient with the KafkaAdminClient, the only differences are the configs. Here is a list of configs defined in StreamsConfig that will be used in StreamsKafkaClient:

• StreamsConfig.CLIENT_ID_CONFIG: still used in KafkaAdminClient.
• StreamsConfig.RETRY_BACKOFF_MS_CONFIG: still used in KafkaAdminClient.
• StreamsConfig.METADATA_MAX_AGE_CONFIG: still used in KafkaAdminClient.
• StreamsConfig.CONNECTIONS_MAX_IDLE_MS_CONFIG: still used in KafkaAdminClient.
• StreamsConfig.RECONNECT_BACKOFF_MS_CONFIG: still used in KafkaAdminClient.
• StreamsConfig.RECONNECT_BACKOFF_MAX_MS_CONFIG: still used in KafkaAdminClient.
• StreamsConfig.SEND_BUFFER_CONFIG: still used in KafkaAdminClient.
• StreamsConfig.RECEIVE_BUFFER_CONFIG: still used in KafkaAdminClient.
• StreamsConfig.REQUEST_TIMEOUT_MS_CONFIG: still used in KafkaAdminClient.
• StreamsConfig.BOOTSTRAP_SERVERS_CONFIG: still used in KafkaAdminClient.
  

So none of the defined properties in StreamsConfig need to be deprecated or removed. No Changes here.

Compatibility, Deprecation, and Migration Plan

• Since we are only adding a new function in the public API, it is binary compatible though not source compatible; users are only required to make one-line change and recompile if they customize the KafkaClientSupplier.
• Note that the admin metrics would be a bit different:
  • "clientID" : [user-value] -> "[clientId]-admin"
  • "type": "kafka-client-metrics" -> "admin-client-metrics"
    

Rejected Alternatives

None