Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Table of Contents

Status

Current state: Under Discussion [One of "Under Discussion", "Accepted", "Rejected"] Accepted (vote thread)

Discussion threadhere

JIRAKAFKA-6923

...

Code Block
languagejava
titleSerializer
linenumberstrue
public interface Serializer<T> extends Closeable {

    void configure(Map<String, ?> configs, boolean isKey);

    default byte[] serialize(String topic, T data);

    default byte[] serialize(String topic, Headers headers, T data) {                        // This is the new method
        return serialize(topic, data);
    }

    @Override
    void close();
}

...

Code Block
languagejava
titleDeserializer
linenumberstrue
public interface Deserializer<T> extends Closeable {

    void configure(Map<String, ?> configs, boolean isKey);

    default T deserialize(String topic, byte[] data);

    default T deserialize(String topic, Headers headers, byte[] data) {                      // This is the new method
        return deserialize(topic, data);
    }

    @Override
    void close();
}

...

Review existing unit tests and system tests.

Manual verification of binary compatibility: existing ExtendedSerializer implementations should work without recompiling the application.

Rejected Alternatives

The code examples here are made with the Deserializer class but they are completely valid for the Serializer as well.

...