Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Table of Contents

Status

Current state:  Under DiscussionAccepted

Discussion thread: here

JIRA: here

...

For use-cases where customers only run MM2 for replicating between clusters without the need for moving the consumer group offsets by running only MirrorSourceConnector. They still left with part#1  Part#1 (blocking until commit) of this feature which add still an issue as it adds cost to the progress of their replication. The only workaround reducing the latency cost is by increasing offset.lag.max  to INT_MAX  which will result that the offset will never going to be queued for offset sync (Check `PartitionState::update` for details on how MM2 decided if it should emit an offset sync or not) however this doesn't eliminate the cost of creating an internal topic. 

This KIP propose proposes that we add a new config for MirrorSourceConnector  to control enabling the offsets translation between clusters for replicated topics.

...

PropertiesDefaultDescription
emit.offset-syncs.enabled true

Whether to store the new offset of the replicated records in offset-syncs topic or not. MirrorCheckpointConnector will fail to start if emit.checkpoints.enabled and/or sync.group.offsets.enabled are enabled while emit.offset-syncs.enabled  are disabled.

Proposed Changes

  • Similar to emit.checkpoints.enabled 

...

  •  and emit.heartbeat.enabled   this KIP will add emit.offset-syncs.enabled . The config default value will be true to keep the current implementation.

  • offset-syncs topic will not be created if emit.offset-syncs.enabled

...

  •   set to false 

  • logic to publish offset syncs in commit()  will not be executed if emit.offset-syncs.enabled

...

  •   set to false 

  • MirrorCheckpointConnector  validation will fail at start if emit.offset-syncs.enabled

...

  •  disabled while emit.checkpoints.enabled  and/or sync.group.offsets.enabled  are enabled. 

Compatibility, Deprecation, and Migration Plan

emit.offset-syncs.enabled  is set to true by default so any existing use-cases or use-cases that run this feature will do nothing. Only use-case that wish to fully disable this feature will need to set emit.offset-syncs.enabled to false.

Rejected Alternatives

  • Reuse emit.checkpoints.enabled   and sync.group.offsets.enabled

...

  •  and assume that if both are disabled then this feature needs to be fully disabled. I didn't want to

...

  • rely on MirrorCheckpointConnector

...

  •   configs to configure MirrorSourceConnector . And this might impact customers who enabled  MirrorSourceConnector  with intention to run MirrorCheckpointConnector  later in the future