Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

2. Filters has orders, so the order they appear in the configuration file should be maintained. And some filter has to be the first one in the filter chain. I could not get an idea to guarantee this elegantly other than give some comment in the configuration file or in the documentation.

3. I will modify the digestor code in order to load the configuration about filters in, ContextRuleSet.java, EngineRuleSet.java, HostRuleSet.java in particular. And those filters information will be store in an order map (I'd like to choose treeMap now) – TreeMap<FilterMetaInfo, Filter>. The FilterMetaInfo class is generally like this:

private final FilterLevels level;

private final int order;

FilterLevels is an enum which contains: ENGINE, HOST, CONTEXT.

4. Do I need to remove all the pipeline facility or can I try to remove as much logic as possible from StandardEngineValve StandardHostValve/StandardHostValve? I found that those valve just delegate to the lower level pipeline(valves), and the lowest StandardWrapperValve will actually finish the job (filterChain and/or the servlet invocation).

...