Page History

...

2007-02-09: Struts 1.3 has been branched. 1.3.x maintenance branch has been branched out. The HEAD represents future 1.4 version and is open for improvements.

Code Issues

1. Wiki Markup
   \[MichaelJ\] *Consider the option to call all lifecycle functions explicitly* from an action class, allow to disable automatic form population. \\

   • Wiki Markup
     \[FrankZ\] I personally would not want to see the auto-population and validation and such go away. I think them being declarative is a powerful notion. I DO however agree that a developer should be able to turn them off declaratively and do it all manually. \\

   • Implemented on 2007-02-09: ActionForm autopopulation is now configurable from an action mapping via "populate" attribute. Automatic call to ActionForm.reset is now configurable from an action mapping via "reset" attribute. See http://svn.apache.org/viewvc?view=rev&revision=505640
     

2. Wiki Markup

   *The ability to switch off auto-form population* \[FrankZ\] The idea here is that Struts would still instantiate an ActionForm and call reset(), but that's it. This can be useful if you want to use an ActionForm only as an output object, but want to handle input manually. This came up for me converting a non-Struts app to Struts, where there was no notion of an ActionForm in the previous framework.

   • Wiki Markup
     \[MichaelJ\] +1 I even had the [ticket|http://issues.apache.org/bugzilla/show_bug.cgi?id=38620] opened for this issue, but as Martin Cooper pointed out, this can be achieved simply by not associating the form with setup action. On the other hand, having form name explicitly in the action mapping makes config file more readable.

   • Implemented on 2007-02-09: (see previous bullet)
     

3. Wiki Markup
   *Base Action class should implement event handling a.k.a. dispatching* \[MichaelJ\] If event is recognized for an action, it is dispatched to a corresponding method. If event is not found in the request, then execute() is called like for a regular action. \\

4. Wiki Markup
   *Built-in support for RAP (Redirect After Post) pattern* \[FrankZ\] I'm not sure how best to accomplish this, but this should be a very easy thing for a developer to do, the framework should do any required heavy lifting. Again, not so much a rough spot as it is something I think a lot of people would appreciate.

   • Wiki Markup
     \[MichaelJ\] To simplify redirect-after-post pattern, Struts must implement Flash scope, that is, the scope that survives after redirect, but is automatically cleaned up after redirected request finishes. Currently similar pattern is applied to the messages queued to session scope. \\

5. Wiki Markup
   *Pure POJO ActionForms* \[FrankZ\] An ActionForm should not need to extend ActionForm. The framework would have to be smart enough to not call validate() and such in that case. This would allow for the Action to be the ActionForm as well, and this is really the underlying goal because many people view them being separate as a rough spot.

   • Wiki Markup
     \[MichaelJ\] Definite +1 \\

6. Wiki Markup
   *Built-in AJAX support* \[FrankZ\] I am not entirely sure what the best form for this is, although I believe the [AjaxTags|http://struts.sourceforge.net/ajaxtags/index.html] paradigm still has a great deal of merit. In any case, in today's world, not offering some degree of AJAX out of the box is probably a rough spot for many.

   • Wiki Markup
     \[MichaelJ\] I believe that I can combine my [JSP Controls Tag Library|http://www.jspcontrols.net/] with Tiles, building a real component subframework on top of Struts, having built-in Ajax features as well (actually, AHAH. It is coarse-grained in-place update of a component within a composite page.) I believe that it can coexist nicely with more finegrained approach of AjaxTags. \\

7. Implement scope that lasts beyond one roundtrip, but shorter than session (a.k.a. RolloverScope, Conversation scope, Flash scope).
   

Best Practices Issues

1. Wiki Markup
   *Dispatch-type actions should be more front-and-center* \[MichaelJ\] Dispatch-action style request processing should become a cornerstone technique instead of "yet another way of doing things". It works especially well in data entry form processing or menu processing. See [DataEntryForm].

   • Wiki Markup
     \[FrankZ\] As an oft-stated opponent, GENERALLY, of Dispatch-type Actions, I wouldn't be thrilled with this being sold as a "best practice". I would have no problem with it being described in more detail and the pluses and minuses stated for people to be able to make a more informed decision either way. \\

2. Wiki Markup
   *Preference for session-scoped ActionForms* \[MichaelJ\] Best practices should explain that there is nothing wrong in having session-scoped action forms. Best practices should teach how to build stateful web resources.

   • Wiki Markup

     \[FrankZ\] -1. Saying there is "nothing wrong" with it, I do not believe is true. Speaking as someone who works all day in a large distributed enterprise environment, I am very well aware of the pitfalls of storing things in session and in letting session get too big. I'm not saying I never store anything in session, of course I do! :) But I think people need to know the positives and negatives of doing so and decide what is appropriate in a given use case rather than being told this or that is a "best practice".

   • Wiki Markup
     \[MichaelJ\] My original wording did not have "preference". What I am saying is that session-scoped forms should not be a taboo, and their benefits (as well as pitfalls) should be clearly explained.

   • Wiki Markup
     \[MichaelJ\] After Rollover scope is implemented it should be preferred over session scope for redirect-after-post and other multi-request but relatively short term interactions. \\

Struts Action Framework 1.5.x considerations

...

Consider a "FormContext" mechanism. Rather than "throw-away" a request-based ActionForm, the object could be seralized as a hidden-field or session-object and restored on the next request. Many other frameworks support this behavior now. Struts would have a slightly different spin, since we look at the form as an named entity rather than as an anonymous aggregation of other objects.

1. Wiki Markup
   *Building stateful components* \[MichaelJ\] Best practices should teach how to build stateful and independent web components with Struts. \\

2. Wiki Markup
   *ActionForm as true I/O buffer* \[MichaelJ\] ActionForm should be used as I/O buffer instead of simply collecting user input from request.

   • Wiki Markup
     \[FrankZ\] Could you explain this further? I'm not at all clear on what you mean.

   • Wiki Markup

     \[MichaelJ\] This is what 60% of Struts users do anyway. I guess you do it as well. You have actionform associated with input action. You submit a form, actionform is populated. In case of error or whatnot you render the same JSP page and pull the data from the actionform, it is already there, saved for you by Struts. I use this all the time for data entry use case, but this does not seem to be an officially endorsed and advertised practice. \\

Struts Action Framework 1.6.x considerations

...

Other considerations

Code Issues

1. Wiki Markup
   \[MichaelJ\] *Consider bringing [FormDef|https://formdef.dev.java.net/] into Struts core* and recommend using dynaforms with nested business objects as a best practice. Reason: I/O conversion is the suckiest part of Struts 1. \\

2. Wiki Markup
   \[MichaelJ\] *Deprecate automatic validation*. Newbies always stumble upon the fact that their action class is not called when validation fails. Instead, promote explicit validation.

   • Wiki Markup
     \[FrankZ\] Definite -1 from me. Again, I'm +1 to being able to turn it on and off, but I very much believe it should be there. Perhaps there is some room for better logging in the cases you mention? \\

3. Wiki Markup
   \[MichaelJ\] *Deprecate "input" attribute* of "action" tag in struts-config.xml. At least, rename it to "error" or something. A frequent misconception is to think that the lifecycle starts with displaying an "input" page, which is obviously not true.

   • Wiki Markup

     \[FrankZ\] +0. I don't disagree with you at all, and I think there are probably other things that could similarly be changed. However, I think it is very important that anything done with Struts 1 be evolutionary and take backwards-compatibility into consideration in a big way. I think if you want revolution you go for Struts 2 (a minor revolution in that it's theoretically still compatible) or Shale. \\

4. Wiki Markup
   \[MichaelJ\] *Add "form" attribute* with the same meaning as "name" attribute; deprecate "name".

   • Wiki Markup
     \[FrankZ\] +0. Same comment as the above point. \\

5. Wiki Markup
   \[FrankZ\] *Actions should be instantiated for each request*, therefore removing the thread safety concerns that exist today.

   • Wiki Markup
     \[MichaelJ\] -0. Not sure that this bothers me anymore, especially if dynaforms will be adopted as standard practice. In this case a dynaform would be a container for a nested business object. I would rather combine Action and ActionForm and have an option to choose scope just right now a scope can be chosen for an ActionForm. That is, I am against strictly per-request actions. \\

6. Wiki Markup

   *Custom attributes on tags* \[FrankZ\] All Struts tags that render HTML should allow for arbitrary attributes. I again propose a "specCompliant" attribute on the <html:html> tag. When true, no arbitrary attributes are allowed (this would be the default if the attribute is not present). If false, any attribute can be added. This has been a hassle for me a couple of times where I wanted to store some custom information on a tag for client-side purposes.

   • Wiki Markup
     \[MichaelJ\] +1 \\

7. Wiki Markup

   *Built-in dependency injection* \[FrankZ\] This should be modeled after what is offered in JSF. If we took the code from the DependencyFilter in [Java Web Parts|http://javawebparts.sourceforge.net/], added in true injection (shouldn't be a terribly big deal), I believe we would have even better capabilities than in JSF. Spring is of course still out there for those that need/want more! This may not be so much a rough spot as just a fairly low-hanging piece of fruit (because most of the work is already done by virtue of leveraging DependencyFilter) that I think people would appreciate having. \\

8. Wiki Markup
   *ThreadLocal ActionContext* \[FrankZ\] Yes, I think this is one place we should flat-out rip off Webwork :) Backwards-compatibility would have to be considered, but I'd like Actions to have to deal with a single object, and for that object to be accessible via the ThreadLocal mechanism. This should also open the door for POJO Actions. \\

9. Wiki Markup
   *Pre and post-processing abilities* \[FrankZ\] A developer should be able to specify a class and method to call before and after an Action executes, on a per-mapping basis. This should be independant of modifying a chain. Should just amount to adding the appropriate config file changes and two commands to the default chain. This is for handling things like common setup of view-type Actions, etc.

   • Wiki Markup
     \[MichaelJ\] +0. I prefer having 1:1 correspondence between mapping and action class. With autopopulation out of the way, I can call whatever I want right in the beginning and at the end of execute() method. Same thing, but simpler, I think. \\

10. Wiki Markup
    *MAYBE roll StrutsWS into Struts* \[FrankZ\] Heck, I'm not even sure \*I\* would +1 this idea! Might be worth considering at least. \\ \\

Documentation Issues

1. Wiki Markup
   *Chain documentation* \[MichaelJ\] Struts 1.3.x introduces the concept of chain of commands, but there is no comprehensive documentation on how this new architecture can be used for initial request processing (as a substitute to solid [RequestProcessor]) as well as for business processing (using Commands instead of Actions, etc). \\

2. Wiki Markup
   *Taglib docs are confusing* \[MichaelJ\] Taglib reference uses too many words for simple things. Words like "attribute", "value", "property" used in different contexts, which does not help much in understanding how the tags really work. Also, Taglib docs should show one best way of doing things instead of saying that one can use this, or this or this in combination with this. \\

3. Wiki Markup
   *Visual representation of tags that render widgets* \[MichaelJ\] Tags that render widgets should have examples and pictures. Here is some initial work in attempt to improve this: [StrutsWidgets]. \\

Best Practices Issues

1. Wiki Markup
   *Focus on best and most common approaches* \[MichaelJ\] Instead of having several ways to do things, Struts 1 should focus on one best and the most common way, even if it involves a couple more lines of code. Less is more. \\

2. Wiki Markup
   *Webresource-centered approach* \[MichaelJ\] Up until now Struts 1 best practices center around a View, usually a JSP page. Instead, best practices should teach the webresource-centered approach.

   • Wiki Markup
     \[FrankZ\] Speaking for myself, I would need to see a good definition of this approach before I was +/- on it. I have never seen a clear explanation that made me say "oh yeah, I see, that's better!"

   • Wiki Markup

     \[MichaelJ\] Check out [DataEntryForm]. Well, it uses dispatching action and session-scoped form, but if you look at it from 10000 ft, it gives the idea of what web resource is about. Basically, it is one-two actions, one form and one or more JSPs. A resource does NEVER forwards to a JSP page that does not belong to the resource. In the best case we can have nice and simple 1:M relationship between action and JSPs. \\

3. Wiki Markup
   *Use of nested properties* \[MichaelJ\] Emphasize using of nested properties, using business objects as nested properties, using dynaforms holding business objects. \\

Relevant Proposals

• Commons Chain of Responsiblity package
• Struts Chain Request Processor
• Struts Classic Release Plan 1.3.0
• struts-faces taglib
• Struts Jericho
• Struts Shale
• Struts Ti
• Struts OverDrive