Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • Building and testing is often done on the command line or at least via the Maven support in the IDEs. 
  • Set up the IDE to follow the source layout rules of the project. 
  • Disable any added value "reformat" and "strip trailing spaces" features as it can create extra noise when reviewing patches.  

Build Tools

Ensure these are installed by executing mvn, git and javac respectively.  

Please see BUILDING.txt for the detail.

As the Hadoop builds use the external Maven repository to download artifacts, Maven needs to be set up with the proxy settings needed to make external HTTP requests. The first build of every Hadoop project needs internet connectivity to download Maven dependencies.

...

  1. The patch is targeting a release branch that is not based off trunk e.g. branch-3.1, branch-02.23 10, etc. 
  2. The change is targeting a specific feature branch and is not yet ready for merging into trunk.  

If you are unsure of the target branch then trunk is usually the best choice. Committers will usually merge the patch to downstream branches e.g. branch-3.2 as appropriate.  

Unit Tests

...

Jenkins includes a javadoc run on Java 8, which is stricter than Java 7: it will fail if there are unbalanced HTML tags or <p/> clauses (use <p> here.  

...

  • Create and attach a diff in ASF JIRA
  • Create a pull request in GitHub

Creating a patch

Check to see what files you have modified with:

...