Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Change the Auditor inteface slightly.

...

Code Block
languagejava
titleAuditor
linenumberstrue
package org.apache.kafka.server.auditor;

import org.apache.kafka.common.Configurable;
import org.apache.kafka.common.acl.AclOperation;
import org.apache.kafka.common.protocol.Errors;
import org.apache.kafka.common.requests.AbstractRequest;
import org.apache.kafka.common.resource.PatternType;
import org.apache.kafka.common.resource.ResourcePattern;
import org.apache.kafka.common.resource.ResourceType;
import org.apache.kafka.server.authorizer.AuthorizableRequestContext;

import java.util.CollectionsList;
import java.util.Map;

/**
 * An auditor class that can be used to hook into the request after its completion and do auditing tasks, such as
 * logging to a special file or sending information about the request to external systems.
 * Threading model:
 * <ul>
 *     <li>The auditor implementation must be thread-safe.</li>
 *     <li>The auditor implementation is expected to be asynchronous with low latency as it is used in performance
 *     sensitive areas, such as in handling produce requests.</li>
 *     <li>Any threads or thread pools used for processing remote operations asynchronously can be started during
 *     start(). These threads must be shutdown during close().</li>
 * </ul>
 */
public interface Auditor extends Configurable, AutoCloseable {

    class AuditInfo {
        private final ResourcePattern resource;
        private final Boolean allowed;
        private final Errors error;

        public static class Builder {
            private ResourcePattern resource;
            private Boolean allowed;
            private Errors error;

            public Builder resource(ResourcePattern resource) {
                this.resource = resource;
                return this;
            }

            public Builder allowed(Boolean allowed) {
                this.allowed = allowed;
                return this;
            }

            public Builder error(Errors error) {
                this.error = error;
                return this;
            }

            public AuditInfo build() {
                return new AuditInfo(resource, allowed, error);
            }
        }

        public AuditInfo(ResourcePattern resource, Boolean allowed, Errors error) {
            this.resource = resource;
            this.allowed = allowed;
            this.error = error;
        }

        public AuditInfo(ResourceType resourceType, String resourceName,
                         Boolean allowed, Errors error) {
            this.resource = new ResourcePattern(resourceType, resourceName, PatternType.LITERAL);
            this.allowed = allowed;
            this.error = error;
        }

        public AuditInfo(ResourceType resourceType, String resourceName, Boolean allowed) {
            this.resource = new ResourcePattern(resourceType, resourceName, PatternType.LITERAL);
            this.allowed = allowed;
            this.error = Errors.NONE;
        }

        public ResourcePattern resource() {
            return resource;
        }

        public Boolean allowed() {
            return allowed;
        }

        public Errors error() {
            return error;
        }
    }

    /**
     * Any threads or thread pools can be started in this method. These resources must be closed in the {@link #close()}
     * method.
     */
    void start();

    /**
     * Called on request completion before returning the response to the client. It allows auditing multiple resources
     * in the request, such as multiple topics being created.
     * @param request is the request that has been issued by the client.
     * @param requestContext contains metadata to the request.
     * @param actionauditInfo is the operation, that is being performed byresource and the client.
     * @param isAllowed is a mapping of resources to booleans to represent whether performing the action is allowed on
     * the resource in the key.outcome of the authorization with the possible error
     * @param errors is a mapping of resources to errors to represent if performing the action on the given result was
     * successful or notcoupled together.
     */
    void audit(AbstractRequest request,
               AuthorizableRequestContext requestContext,
               AclOperation actionMap<AclOperation,
               Map<ResourcePattern, Boolean> isAllowed,
               Map<ResourcePattern, Errors> errorsList<AuditInfo>> auditInfo);
}

The KIP also introduces a new configuration called auditors which is a comma-separated list of Auditor implementations. By default it is configured with the LoggingAuditor default implementation.

...