Versions Compared

Old Version 16

changes.mady.by.user Chia-Ping Tsai

Saved on

compared with

New Version 17

changes.mady.by.user Chia-Ping Tsai

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  1. support the usage of Serializers (from Juma): this support could complicate the configs, since users have to define both MessageReader and serializer. It seems to me the mechanism of MessageReader should include serialization.
  2. move RecordReader to "org.apache.kafka.common": "org.apache.kafka.common" does not allow to import code from "org.apache.kafka.clients.producer". However, the tool-related interface should be able to access producer, consumer and admin code. 
  3. new RecordReader implements Configurable: Implementing Configurable will change the arguments of configure method from (InputStream, configs) to (configs). That obstructs RecordReader from keeping input stream itself as some of that state.