Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Table of Contents

Status

Current state[One of "Under Discussion", "Accepted", "Rejected"]

...

Please keep the discussion on the mailing list rather than commenting on the wiki (wiki discussions get unwieldy fast).

Motivation

Currently, it's only possible to add policies for Topic creation and configuration updates via CreateTopicPolicy  (introduced in KIP-108) and AlterConfigPolicy (introduced in KIP-133), but not for Topic deletion.

...

This KIP borrows parts of KIP-170. If KIP-201 is resurrected, this changes shouldn't increase complexity of the KIP as it follows TopicCreatePolicy approach and same migration should apply.

Public Interfaces

1. New interface on clients module:

...

Code Block
DeleteTopics Request (Version: 7) => [topics] timeout validate_only
  topics => STRING
  timeout => INT32
  validate_only => BOOLEAN


Proposed Changes

Apart from the Interfaces proposed, the changes will follow the same approach as TopicCreatePolicy.

...

  • DeleteTopicsRequest:
    • Bump to version 7
    • Add validateOnly  flag to DeleteTopicsRequest.json 
    • Add POLICY_VIOLATION as possible error code on DeleteTopicsResponse 
    • Add options to DeleteTopicsOptions 
    • Use new flag on KafkaAdminClient 
    • Extend Controller#deleteTopics interface to include DeleteTopicsRequestData and update implementations
  • DeleteTopicPolicy:
    • Add policy config to KafkaConfig 
    • Load policy and pass it to Controllers  and ZKAdminManager .
    • Use policy on ReplicationControlManager 

Compatibility, Deprecation, and Migration Plan

  • What impact (if any) will there be on existing users?

No impact to existing users. All are new APIs, and should not have any compatibility issues apart from validating that validateOnly  flag on protocol is only requested for version 7 of DeleteTopicsRequest message.

Test Plan

Fairly similar to TopicCreatePolicy, checking that config is loaded properly, and policy validation returns proper exception.

Rejected Alternatives

  • Protecting Topics with ACLs:
    • As stated on the motivation, this approach is insufficient, as even when authorization is there topic deletion errors can occur.