Versions Compared

Old Version 18

changes.mady.by.user Nate Cole

Saved on

compared with

New Version Current

changes.mady.by.user Vivek Ratnavel Subramanian

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Please refer to How to Contribute for instructions how to submit a code review to http://reviews.apache.orgto Github.

What makes a good code review?

...

We have a global community of committers, so please be mindful that you should wait at least 24 hours before pushing merging your patch pull request even though you may already have the necessary +1.
This encourages others to take an interest in your review pull request and helps us find more bugs (it's ok to slow down in order to speed up).

Always include the "Ambari" group in the code review and  at least two committers that are familiar with that code area.
If you want to subscribe to code reviews for a particular area, feel free to edit this section.

...