WORK IN PROGRESS

To be Reviewed By:

Authors: Dan Smith

Status: Draft | Discussion | Active | Dropped | Superseded

Superseded by: N/A

Related: N/A

Problem

Geode contributors don't always know who the right people are to tag on a review. Geode committers also tend to review and approve pull requests based on different criteria - for example to see if the documentation is well written, or if the code meets minimum standards for including tests, etc. We want to ensure that all PRs are routed to subject matter experts that can review the substantive changes of the PR, and ensure that contributors and committers can identify that a PR has been reviewed by someone with expertise in the correct area.

Solution

We would like to use a github CODEOWNERS file to indicate owners for different areas of the code. Below is the a breakdown of different areas of the code that need owners. None of these areas should have a single owner, and we foresee that owners can rotate over time. By being marked an owner, a committer will automatically be added as a reviewer for a PR that changes these areas.

geode repository CODEOWNERS

Please see this draft codeowners file.

Other repositories

These repositories are smaller and only need a single set of code owners for each repository.

• geode-native
• geode-examples
• geode-benchmarks
• geode-site
• geode-kafka-connector
• geode-dotnet-core-client

Prior Art

What would be the alternatives to the proposed solution? What would happen if we don’t solve the problem? Why should this proposal be preferred?

FAQ

Answers to questions you’ve commonly been asked after requesting comments for this proposal.

Errata

What are minor adjustments that had to be made to the proposal since it was approved?